Bugzilla – Attachment 192899 Details for
Bug 10190
Overdue notice triggers based on item type
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10190: fix: prevent duplicate ruleset load
Bug-10190-fix-prevent-duplicate-ruleset-load.patch (text/plain), 2.91 KB, created by
ChloƩ Zermatten
on 2026-02-10 13:09:09 UTC
(
hide
)
Description:
Bug 10190: fix: prevent duplicate ruleset load
Filename:
MIME Type:
Creator:
ChloƩ Zermatten
Created:
2026-02-10 13:09:09 UTC
Size:
2.91 KB
patch
obsolete
>From d476d80fc6640c8bb9ecd924efebf1b1bf5f7fe2 Mon Sep 17 00:00:00 2001 >From: Chloe Zermatten <chloe.zermatten@openfifth.co.uk> >Date: Mon, 9 Feb 2026 15:02:57 +0000 >Subject: [PATCH] Bug 10190: fix: prevent duplicate ruleset load > >- prevent the initial API call and subsequent exhaustive applied ruleset list generation logic from running twice >--- > .../CirculationTriggersList.vue | 17 ++++++++--------- > .../prog/js/vue/stores/circulation-rules.js | 6 ++++++ > 2 files changed, 14 insertions(+), 9 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Admin/CirculationTriggers/CirculationTriggersList.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Admin/CirculationTriggers/CirculationTriggersList.vue >index 4f52ad12663..a11b9940efe 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Admin/CirculationTriggers/CirculationTriggersList.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Admin/CirculationTriggers/CirculationTriggersList.vue >@@ -336,12 +336,6 @@ export default { > displayAllApplicableRules: 1, > }; > }, >- beforeRouteEnter(to, from, next) { >- next(async vm => { >- vm.filtersInitialized = true; >- await vm.filterRuleSetsbySearchParam(); >- }); >- }, > methods: { > async loadRuleSets() { > this.ruleSetInitialized = false; >@@ -429,11 +423,16 @@ export default { > this.showModal = newVal.meta && newVal.meta.showModal; > }, > }, >- "$route.query.refresh": { >- async handler(newVal) { >- if (newVal) { >+ "$route.query": { >+ async handler() { >+ if ( >+ this.$route.fullPath.includes("refresh") || >+ this.$route.path.endsWith("circulation_triggers") >+ ) { >+ await this.$nextTick(); > await this.filterRuleSetsbySearchParam(); > } >+ this.filtersInitialized = true; > }, > immediate: true, > }, >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/stores/circulation-rules.js b/koha-tmpl/intranet-tmpl/prog/js/vue/stores/circulation-rules.js >index 3594fe63aa9..5129a704107 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/stores/circulation-rules.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/stores/circulation-rules.js >@@ -400,6 +400,12 @@ export const useCircRulesStore = defineStore("circRules", () => { > {}, > { library_id: "*", effective: false } > ); >+ if (this.currentLibraryId === "*") { >+ this.allCurrentLibraryRawRuleSets = >+ this.allDefaultLibraryRawRuleSets; >+ return; >+ } >+ > this.allCurrentLibraryRawRuleSets = await client.circ_rules.getAll( > {}, > { library_id: this.currentLibraryId, effective: false } >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10190
:
170357
|
170358
|
170359
|
170360
|
170361
|
170362
|
170363
|
170364
|
170365
|
170366
|
170367
|
170368
|
170369
|
170370
|
170371
|
170372
|
170373
|
170374
|
170375
|
170376
|
170380
|
170449
|
171727
|
171728
|
171729
|
171730
|
171731
|
171732
|
171733
|
171734
|
171735
|
171736
|
171737
|
171738
|
171739
|
171740
|
171741
|
171742
|
171743
|
171744
|
171745
|
171746
|
171747
|
171748
|
171749
|
171750
|
171751
|
171752
|
171753
|
171754
|
171755
|
172588
|
172589
|
172590
|
172591
|
172592
|
172593
|
172594
|
172595
|
172596
|
172597
|
172598
|
172599
|
172600
|
172601
|
172602
|
172603
|
172604
|
172605
|
172606
|
172607
|
172608
|
172609
|
172612
|
172614
|
172617
|
172619
|
172621
|
172622
|
172623
|
172624
|
172625
|
172626
|
172630
|
172631
|
172632
|
172633
|
172634
|
172635
|
172636
|
172637
|
172638
|
172639
|
172640
|
172641
|
172642
|
172643
|
172644
|
172645
|
172646
|
172647
|
172648
|
172649
|
172650
|
172651
|
172652
|
172653
|
172654
|
172655
|
172656
|
172657
|
172658
|
172659
|
172660
|
172661
|
172662
|
172663
|
178643
|
178644
|
178645
|
178646
|
178647
|
178648
|
178649
|
178650
|
178651
|
178652
|
178653
|
178654
|
178655
|
178656
|
178657
|
178658
|
178659
|
178660
|
178661
|
178662
|
178663
|
178664
|
178665
|
178666
|
178667
|
178668
|
178669
|
178670
|
178671
|
178672
|
178673
|
178674
|
178675
|
188075
|
188076
|
188077
|
188078
|
188079
|
188080
|
188081
|
188082
|
188083
|
188084
|
188085
|
188086
|
188087
|
188088
|
188476
|
189345
|
189863
|
189864
|
189865
|
189866
|
189867
|
189868
|
191749
|
191750
|
191751
|
191752
|
191753
|
191754
|
191755
|
191756
|
191757
|
191758
|
191759
|
191760
|
191761
|
191762
|
191763
|
191795
|
191796
|
191805
|
191854
|
191873
|
192871
|
192872
|
192873
|
192874
|
192875
|
192876
|
192877
|
192878
|
192879
|
192880
|
192881
|
192882
|
192883
|
192884
|
192885
|
192886
|
192887
|
192888
|
192889
|
192890
|
192891
|
192892
|
192893
|
192894
|
192895
|
192896
|
192897
|
192898
| 192899