Bugzilla – Attachment 192979 Details for
Bug 41070
No warning when filling no fund while importing in a basket from a file
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41070: Fix selector in addorderiso validator
Bug-41070-Fix-selector-in-addorderiso-validator.patch (text/plain), 2.27 KB, created by
Baptiste Wojtkowski (bwoj)
on 2026-02-11 14:25:40 UTC
(
hide
)
Description:
Bug 41070: Fix selector in addorderiso validator
Filename:
MIME Type:
Creator:
Baptiste Wojtkowski (bwoj)
Created:
2026-02-11 14:25:40 UTC
Size:
2.27 KB
patch
obsolete
>From 99d3f20b3f956ed5ce117cf6d9ff459af0058af8 Mon Sep 17 00:00:00 2001 >From: Baptiste <baptiste.wojtkowski@biblibre.com> >Date: Wed, 11 Feb 2026 10:56:48 +0100 >Subject: [PATCH] Bug 41070: Fix selector in addorderiso validator > >Steps to reproduce, do not apply patch >1 - Go to any record and click save -> marc (Unicode/utf8) >2 - Go to any vendor and add a basket >3 - In your acquisition grid, make sure "barcode" is mandatory >4 - In this basket, create a new order from file, use the generated file and wait for the end of the import. Click on add staged files to basket. >5 - Select the record, make sure no Fund or barcode is filled, neither in first or third tab. >6 - Validate: There will be an error due to the missing barcode. If >there is another error, fill the missing part of the form. >7 - Apply patch, repeat 6, the error will be due to the missing fund >8 - Select a fund in the first panel -> the error will be due to the >missing barcode >9 - Select a fund in the third panel -> the error will be due to the >missing barcode > >Note: the point about the barcode are not relevant for the bug, they are >just here to prevent the submission of the form. And avoid repeating >steps 4-5. >--- > koha-tmpl/intranet-tmpl/prog/js/addorderiso2709.js | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/addorderiso2709.js b/koha-tmpl/intranet-tmpl/prog/js/addorderiso2709.js >index 366cff95de3..5ba3ff0b49e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/addorderiso2709.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/addorderiso2709.js >@@ -125,9 +125,9 @@ function checkOrderBudgets() { > var unset_funds = 0; > var all_budget_id = $("#all_budget_id"); > // If we don't have an overarching default set we need to check each selected order >- if (!all_budget_id.val()) { >- $("fieldset.biblio.rows.order-selected").each(function () { >- var default_order_fund = $(this).find("[name='budget_id']"); >+ if ( !all_budget_id.val() ) { >+ $(".biblio .order-selected fieldset.rows").each(function(){ >+ var default_order_fund = $(this).find("[name^='budget_id']"); > // For each order we see if budget is set for order > if (!default_order_fund.val()) { > $(this).find(".item_fund.required").show(); >-- >2.43.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41070
:
192970
|
192971
|
192973
| 192979