Bugzilla – Attachment 193000 Details for
Bug 38096
Field 857 is not considered for display on XSLT files
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38096: (QA follow-up): Add URLLinkText to opac xsl also
a481562.patch (text/plain), 4.88 KB, created by
Jonathan Druart
on 2026-02-12 09:07:01 UTC
(
hide
)
Description:
Bug 38096: (QA follow-up): Add URLLinkText to opac xsl also
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2026-02-12 09:07:01 UTC
Size:
4.88 KB
patch
obsolete
>From a481562c9e3f8c29c326a70c7eba2ae85da8dc89 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@openfifth.co.uk> >Date: Wed, 11 Feb 2026 08:24:22 -0100 >Subject: [PATCH] Bug 38096: (QA follow-up): Add URLLinkText to opac xsl also > >Fix error: >[2026/02/11 09:18:00] [WARN] XSLT::Base: runtime error: file /usr/share/koha/opac/htdocs/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl line 726 element choose >Variable 'URLLinkText' has not been declared. >Undefined variable > at /usr/share/koha/lib/Koha/XSLT/Base.pm line 231. > >Run tests to prove the patch fixes the issue (this fails before the patch): >prove t/db_dependent/Search.t > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 2 ++ > .../opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl | 2 ++ > koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl | 1 + > 3 files changed, 5 insertions(+) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl >index 3e0d3a51b24..1795788a76d 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl >@@ -1074,6 +1074,7 @@ > <xsl:with-param name="Show856uAsImage" select="$Show856uAsImage"></xsl:with-param> > <xsl:with-param name="OPACTrackClicks" select="$OPACTrackClicks"></xsl:with-param> > <xsl:with-param name="OPACURLOpenInNewWindow" select="$OPACURLOpenInNewWindow"></xsl:with-param> >+ <xsl:with-param name="URLLinkText" select="$URLLinkText"></xsl:with-param> > <xsl:with-param name="screen" select="'detail'"></xsl:with-param> > <xsl:with-param name="biblionumber" select="$biblionumber"></xsl:with-param> > </xsl:call-template> >@@ -1092,6 +1093,7 @@ > <xsl:with-param name="MARCOnlineResourceField">857</xsl:with-param> > <xsl:with-param name="OPACTrackClicks" select="$OPACTrackClicks"></xsl:with-param> > <xsl:with-param name="OPACURLOpenInNewWindow" select="$OPACURLOpenInNewWindow"></xsl:with-param> >+ <xsl:with-param name="URLLinkText" select="$URLLinkText"></xsl:with-param> > <xsl:with-param name="screen" select="'detail'"></xsl:with-param> > <xsl:with-param name="biblionumber" select="$biblionumber"></xsl:with-param> > </xsl:call-template> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl >index 200201b4795..7da9d109bed 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl >@@ -1197,6 +1197,7 @@ > <xsl:with-param name="Show856uAsImage" select="$Show856uAsImage"></xsl:with-param> > <xsl:with-param name="OPACTrackClicks" select="$OPACTrackClicks"></xsl:with-param> > <xsl:with-param name="OPACURLOpenInNewWindow" select="$OPACURLOpenInNewWindow"></xsl:with-param> >+ <xsl:with-param name="URLLinkText" select="$URLLinkText"></xsl:with-param> > <xsl:with-param name="screen" select="'results'"></xsl:with-param> > <xsl:with-param name="biblionumber" select="$biblionumber"></xsl:with-param> > </xsl:call-template> >@@ -1215,6 +1216,7 @@ > <xsl:with-param name="MARCOnlineResourceField">857</xsl:with-param> > <xsl:with-param name="OPACTrackClicks" select="$OPACTrackClicks"></xsl:with-param> > <xsl:with-param name="OPACURLOpenInNewWindow" select="$OPACURLOpenInNewWindow"></xsl:with-param> >+ <xsl:with-param name="URLLinkText" select="$URLLinkText"></xsl:with-param> > <xsl:with-param name="screen" select="'results'"></xsl:with-param> > <xsl:with-param name="biblionumber" select="$biblionumber"></xsl:with-param> > </xsl:call-template> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl >index d09c8da4df8..4f49f8661b7 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl >@@ -700,6 +700,7 @@ > <xsl:param name="OPACTrackClicks" /> > <xsl:param name="OPACURLOpenInNewWindow" /> > <xsl:param name="screen" /> >+ <xsl:param name="URLLinkText" /> > <xsl:param name="biblionumber" /> > > <xsl:for-each select="marc:datafield[@tag=$MARCOnlineResourceField and marc:subfield[@code='u']]"> >-- >2.43.0 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38096
:
172466
|
172467
|
172468
|
172469
|
172470
|
172471
|
172532
|
172533
|
172534
|
172535
|
172536
|
192376
|
192377
|
192378
|
192379
|
192380
|
192381
|
192589
|
192590
|
192591
|
192592
|
192593
|
192594
|
192813
|
192814
|
192815
|
192816
|
192817
|
192818
|
192819
|
192906
|
192907
|
192908
|
192909
|
192910
|
192911
|
192919
|
192920
|
192921
|
192922
|
192966
| 193000