Bugzilla – Attachment 19301 Details for
Bug 10494
KohaBranchName sends useless warnings to log if supplied library code is null or not present
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 10494: test cases for the KohaBranchName plugin
PASSED-QA-Bug-10494-test-cases-for-the-KohaBranchN.patch (text/plain), 2.36 KB, created by
Katrin Fischer
on 2013-06-30 17:17:42 UTC
(
hide
)
Description:
[PASSED QA] Bug 10494: test cases for the KohaBranchName plugin
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2013-06-30 17:17:42 UTC
Size:
2.36 KB
patch
obsolete
>From e6c59eea74d43f722c9590a7190bb225cdbb5f81 Mon Sep 17 00:00:00 2001 >From: Galen Charlton <gmc@esilibrary.com> >Date: Wed, 19 Jun 2013 08:47:34 -0700 >Subject: [PATCH] [PASSED QA] Bug 10494: test cases for the KohaBranchName > plugin > >To test, in a test database that has the sample branches >loaded, run > >prove -v t/db_dependent/Koha_template_plugin_KohaBranchName.t > >Note that this includes regression tests for the issues >reported in bug 10494; these won't pass without applying >the patch that fixes them. > >Signed-off-by: Galen Charlton <gmc@esilibrary.com> >Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >--- > .../Koha_template_plugin_KohaBranchName.t | 37 ++++++++++++++++++++ > 1 file changed, 37 insertions(+) > create mode 100644 t/db_dependent/Koha_template_plugin_KohaBranchName.t > >diff --git a/t/db_dependent/Koha_template_plugin_KohaBranchName.t b/t/db_dependent/Koha_template_plugin_KohaBranchName.t >new file mode 100644 >index 0000000..dbba6da >--- /dev/null >+++ b/t/db_dependent/Koha_template_plugin_KohaBranchName.t >@@ -0,0 +1,37 @@ >+#!/usr/bin/perl >+ >+# Copyright 2013 Equinox Software, Inc. >+# >+# This file is part of Koha. >+# >+# Koha is free software; you can redistribute it and/or modify it under the >+# terms of the GNU General Public License as published by the Free Software >+# Foundation; either version 3 of the License, or (at your option) any later >+# version. >+# >+# Koha is distributed in the hope that it will be useful, but WITHOUT ANY >+# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR >+# A PARTICULAR PURPOSE. See the GNU General Public License for more details. >+# >+# You should have received a copy of the GNU General Public License along >+# with Koha; if not, see <http://www.gnu.org/licenses>. >+ >+use Modern::Perl; >+ >+use Test::More tests => 5; >+ >+BEGIN { >+ use_ok('Koha::Template::Plugin::KohaBranchName'); >+} >+ >+my $filter = Koha::Template::Plugin::KohaBranchName->new(); >+ok($filter, "initialized KohaBranchName plugin"); >+ >+my $name = $filter->filter('CPL'); >+is($name, 'Centerville', 'retrieved expected name for CPL'); >+ >+$name = $filter->filter('__ANY__'); >+is($name, '', 'received empty string as name of the "__ANY__" placeholder library code'); >+ >+$name = $filter->filter(undef); >+is($name, '', 'received empty string as name of NULL/undefined library code'); >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10494
:
19157
|
19158
|
19292
|
19293
| 19301 |
19302