Bugzilla – Attachment 193025 Details for
Bug 41788
Make running the holds queue on click optional
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41788: Implement UseHoldsQueueFilterOptions
Bug-41788-Implement-UseHoldsQueueFilterOptions.patch (text/plain), 4.87 KB, created by
Brendan Lawlor
on 2026-02-12 19:22:55 UTC
(
hide
)
Description:
Bug 41788: Implement UseHoldsQueueFilterOptions
Filename:
MIME Type:
Creator:
Brendan Lawlor
Created:
2026-02-12 19:22:55 UTC
Size:
4.87 KB
patch
obsolete
>From 5f2944a2e2c9f5cd57bd09593a07d099e4a6f69e Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Fri, 6 Feb 2026 15:22:56 +0000 >Subject: [PATCH] Bug 41788: Implement UseHoldsQueueFilterOptions > >To test: >1. Apply patch, updatedatabase, restart_all >2. Search for new system preference UseHoldsQueueFilterOptions. >3. Disable it, and navigate to Circulation -> Holds queue >4. With the pref disabled the holds queue should run with asking for filters. >5. Also try the Holds queue link in the circ-nav ( left navigation ) panel, clicking it should automatically run the holds queue. >6. Also try the link in the breadcrumbs, clicking it should automatically run the holds queue. >7. Now enabled the pref. >8. With the pref enabled navigate to Circulation -> Holds queue, the holds queue link should present filters but NOT run the holds queue. >9. Test the Holds queue link in the circ-nav ( left navigation ) panel, click it should present filters but NOT run the holds queue. >10. Also try the link in the breadcrumbs, clicking them should presnt filters but not run the holds queue. > >Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/circ-nav.inc | 6 +++++- > .../intranet-tmpl/prog/en/modules/circ/circulation-home.tt | 6 +++++- > .../intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt | 6 +++++- > 3 files changed, 15 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-nav.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-nav.inc >index 07cb781c34..7f15bbe094 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-nav.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-nav.inc >@@ -46,7 +46,11 @@ > <h5>Holds</h5> > <ul> > <li> >- <a href="/cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit=[% Branches.GetLoggedInBranchcode | uri %]&run_report=1">Holds queue</a> >+ [% IF Koha.Preference('UseHoldsQueueFilterOptions') %] >+ <a href="/cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit=[% Branches.GetLoggedInBranchcode | uri %]">Holds queue</a> >+ [% ELSE %] >+ <a href="/cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit=[% Branches.GetLoggedInBranchcode | uri %]&run_report=1">Holds queue</a> >+ [% END %] > </li> > <li> > <a href="/cgi-bin/koha/circ/pendingreserves.pl">Holds to pull</a> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt >index 5def67f655..b6804b4f0b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt >@@ -80,7 +80,11 @@ > > <ul class="buttons-list"> > <li> >- <a class="circ-button holds-queue" href="/cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit=[% Branches.GetLoggedInBranchcode | uri %]&run_report=1"><i class="fa fa-tasks"></i> Holds queue</a> >+ [% IF Koha.Preference('UseHoldsQueueFilterOptions') %] >+ <a class="circ-button holds-queue" href="/cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit=[% Branches.GetLoggedInBranchcode | uri %]"><i class="fa fa-tasks"></i> Holds queue</a> >+ [% ELSE %] >+ <a class="circ-button holds-queue" href="/cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit=[% Branches.GetLoggedInBranchcode | uri %]&run_report=1"><i class="fa fa-tasks"></i> Holds queue</a> >+ [% END %] > </li> > <li> > <a class="circ-button holds-to-pull" href="/cgi-bin/koha/circ/pendingreserves.pl"><i class="fa-solid fa-hand-back-fist"></i> Holds to pull</a> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt >index facdba8433..772715e9bb 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt >@@ -43,7 +43,11 @@ > [% END %] > [% IF ( run_report ) %] > [% WRAPPER breadcrumb_item %] >- <a href="/cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit=[% Branches.GetLoggedInBranchcode | uri %]&run_report=1">Holds queue</a> >+ [% IF Koha.Preference('UseHoldsQueueFilterOptions') %] >+ <a href="/cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit=[% Branches.GetLoggedInBranchcode | uri %]">Holds queue</a> >+ [% ELSE %] >+ <a href="/cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit=[% Branches.GetLoggedInBranchcode | uri %]&run_report=1">Holds queue</a> >+ [% END %] > [% END %] > [% WRAPPER breadcrumb_item bc_active= 1 %] > <span>Results</span> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41788
:
192634
|
192635
|
192952
|
192953
|
193024
| 193025 |
193026