Bugzilla – Attachment 19304 Details for
Bug 10484
serials-edit.pl not checking for barcode field before checking for barcode subfield
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 10484 - serials-edit.pl not checking for barcode field before checking for barcode subfield
PASSED-QA-Bug-10484---serials-editpl-not-checking-.patch (text/plain), 1.70 KB, created by
Katrin Fischer
on 2013-06-30 19:50:05 UTC
(
hide
)
Description:
[PASSED QA] Bug 10484 - serials-edit.pl not checking for barcode field before checking for barcode subfield
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2013-06-30 19:50:05 UTC
Size:
1.70 KB
patch
obsolete
>From 851f572d26c6a89330507650bfbd3103211e3f89 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Mon, 17 Jun 2013 12:28:13 -0400 >Subject: [PATCH] [PASSED QA] Bug 10484 - serials-edit.pl not checking for > barcode field before checking for barcode subfield > >The script serials-edit.pl is not checking for the existence of the >barcode field before checking for barcode subfield for autoBarcode = >incremental. If the barcode field doesn't exist, the script dies with >errors. > >Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Passes tests and QA script. >Checked that adding items on serial receive still works. >--- > serials/serials-edit.pl | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > >diff --git a/serials/serials-edit.pl b/serials/serials-edit.pl >index 66d3a4e..34f1031 100755 >--- a/serials/serials-edit.pl >+++ b/serials/serials-edit.pl >@@ -318,8 +318,12 @@ if ( $op and $op eq 'serialchangestatus' ) { > if ( C4::Context->preference('autoBarcode') eq > 'incremental' ) > { >- if ( !$bib_record->field($barcodetagfield) >- ->subfield($barcodetagsubfield) ) >+ if ( >+ !( >+ $bib_record->field($barcodetagfield) >+ && $bib_record->field($barcodetagfield)->subfield($barcodetagsubfield) >+ ) >+ ) > { > my $sth_barcode = $dbh->prepare( > 'select max(abs(barcode)) from items'); >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10484
:
19082
|
19199
| 19304