Bugzilla – Attachment 19307 Details for
Bug 9811
Patrons search improvements
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 9811: QA followup
Bug-9811-QA-followup.patch (text/plain), 1.96 KB, created by
Jonathan Druart
on 2013-07-01 08:44:18 UTC
(
hide
)
Description:
Bug 9811: QA followup
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2013-07-01 08:44:18 UTC
Size:
1.96 KB
patch
obsolete
>From d3d3cfbe72e95ea3e878a46305932fb105782896 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Mon, 1 Jul 2013 10:39:06 +0200 >Subject: [PATCH] Bug 9811: QA followup > >removes 2 tabs >removes mysqlisms >--- > C4/Utils/DataTables/Members.pm | 4 ++-- > koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > >diff --git a/C4/Utils/DataTables/Members.pm b/C4/Utils/DataTables/Members.pm >index 2f99d90..caee98e 100644 >--- a/C4/Utils/DataTables/Members.pm >+++ b/C4/Utils/DataTables/Members.pm >@@ -27,7 +27,7 @@ sub search { > } > > my $dbh = C4::Context->dbh; >- my $select = "SELECT SQL_CALC_FOUND_ROWS >+ my $select = "SELECT > borrowers.borrowernumber, borrowers.surname, borrowers.firstname, borrowers.address, > borrowers.address2, borrowers.city, borrowers.zipcode, borrowers.country, > CAST(borrowers.cardnumber AS UNSIGNED) AS cardnumber, borrowers.dateexpiry, >@@ -104,7 +104,7 @@ sub search { > my $patrons = $sth->fetchall_arrayref({}); > > # Get the iTotalDisplayRecords DataTable variable >- $query = "SELECT FOUND_ROWS()"; >+ $query = "SELECT COUNT(*) ". $from . ($where ? $where : ""); > $sth = $dbh->prepare($query); > $sth->execute; > ($iTotalDisplayRecords) = $sth->fetchrow_array; >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc >index 722fec8..3172208 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc >@@ -91,8 +91,8 @@ > <option value="[% categorie.categorycode %]" selected="selected">[% categorie.description %]</option>[% ELSE %] > <option value="[% categorie.categorycode %]">[% categorie.description %]</option>[% END %] > [% END %]</select> >- </p> >- [% END %] >+ </p> >+ [% END %] > </form> > </div> > >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9811
:
16096
|
16111
|
16112
|
16320
|
16362
|
16403
|
16957
|
19056
|
19057
|
19307
|
19633
|
19642
|
20094
|
20095
|
20096
|
20174
|
20266
|
20290
|
20291
|
21169
|
21170
|
21171
|
21172
|
21173
|
21174
|
21175
|
22265
|
23261
|
24095
|
24111
|
26067
|
26068
|
26261
|
26336
|
26337
|
26342
|
26347
|
27642
|
27643
|
27644
|
27645
|
27646
|
27711
|
28738
|
28739
|
28740
|
28741
|
28742
|
28743
|
28744
|
28745
|
28746
|
28747
|
28781
|
28782
|
29019
|
29020
|
29021
|
29022
|
29023
|
29024
|
29025
|
29026
|
29027
|
29028
|
29029
|
29442