Bugzilla – Attachment 19309 Details for
Bug 10124
Pending orders: ergonomic improvement
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10124: QA followup
Bug-10124-QA-followup.patch (text/plain), 2.39 KB, created by
Jonathan Druart
on 2013-07-01 09:50:44 UTC
(
hide
)
Description:
Bug 10124: QA followup
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2013-07-01 09:50:44 UTC
Size:
2.39 KB
patch
obsolete
>From eab1d7998630aeb6dbd5b5208398971f321ac44b Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Mon, 1 Jul 2013 11:35:47 +0200 >Subject: [PATCH] Bug 10124: QA followup > >- Remame the t/.../GetPendingOrders.pm to t/.../SearchOrders.pm according >to the package name. >- Rename IndependantBranches with IndependentBranches >- FIX levels in pod > >Note that 1 qa issue still exists (not introduced by this development): > FAIL t/db_dependent/lib/KohaTest/Acquisition/SearchOrders.pm > OK pod > OK forbidden patterns > FAIL valid > Invalid CODE attribute: Test( 1 ) > OK critic > >These tests are never used. >--- > C4/Acquisition.pm | 2 +- > .../Acquisition/{GetPendingOrders.pm => SearchOrders.pm} | 6 +++--- > 2 files changed, 4 insertions(+), 4 deletions(-) > rename t/db_dependent/lib/KohaTest/Acquisition/{GetPendingOrders.pm => SearchOrders.pm} (98%) > >diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm >index a8498ee..5fb2e10 100644 >--- a/C4/Acquisition.pm >+++ b/C4/Acquisition.pm >@@ -1550,7 +1550,7 @@ sub SearchOrders { > }; > > my $userenv = C4::Context->userenv; >- if ( C4::Context->preference("IndependantBranches") ) { >+ if ( C4::Context->preference("IndependentBranches") ) { > if ( ( $userenv ) and ( $userenv->{flags} != 1 ) ) { > $query .= q{ > AND ( >diff --git a/t/db_dependent/lib/KohaTest/Acquisition/GetPendingOrders.pm b/t/db_dependent/lib/KohaTest/Acquisition/SearchOrders.pm >similarity index 98% >rename from t/db_dependent/lib/KohaTest/Acquisition/GetPendingOrders.pm >rename to t/db_dependent/lib/KohaTest/Acquisition/SearchOrders.pm >index 3f58154..d92aadb 100644 >--- a/t/db_dependent/lib/KohaTest/Acquisition/GetPendingOrders.pm >+++ b/t/db_dependent/lib/KohaTest/Acquisition/SearchOrders.pm >@@ -8,7 +8,7 @@ use Test::More; > > use C4::Acquisition; > >-=head3 no_orders >+=head1 no_orders > > at first, there should be no orders for our bookseller. > >@@ -25,7 +25,7 @@ sub no_orders : Test( 1 ) { > or diag( Data::Dumper->Dump( [ $orders ], [ 'orders' ] ) ); > } > >-=head3 new_order >+=head1 new_order > > we make an order, then see if it shows up in the pending orders > >@@ -82,7 +82,7 @@ sub one_new_order : Test( 49 ) { > for my $field ( @expectedfields ) { > ok( exists( $firstorder->{ $field } ), "This order has a $field field" ); > } >- >+ > } > > 1; >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10124
:
17691
|
17692
|
17693
|
17701
|
18493
|
18494
|
18495
|
18501
|
18502
|
18503
|
19309
|
19636
|
19637
|
19638
|
19639
|
19640