Bugzilla – Attachment 193092 Details for
Bug 23415
Notify patron fines when renewing
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23415: (follow-up) Fix typo 'oweing' -> 'owing' in templates and notices
2f0cd1c.patch (text/plain), 3.67 KB, created by
Martin Renvoize (ashimema)
on 2026-02-13 15:08:26 UTC
(
hide
)
Description:
Bug 23415: (follow-up) Fix typo 'oweing' -> 'owing' in templates and notices
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2026-02-13 15:08:26 UTC
Size:
3.67 KB
patch
obsolete
>From 2f0cd1c2289468f6bb999bb1ae064cb7011a4bfa Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@openfifth.co.uk> >Date: Fri, 13 Feb 2026 15:04:17 +0000 >Subject: [PATCH] Bug 23415: (follow-up) Fix typo 'oweing' -> 'owing' in > templates and notices > >This patch corrects a typo in the auto renewal error code and related >notice templates: >- Adds database update to fix existing notice templates in letter table >- Fixes sample notices for new installations >- Fixes renew_strings.inc template include > >The error code changes from 'auto_too_much_oweing' to 'auto_too_much_owing' >throughout. >--- > installer/data/mysql/atomicupdate/bug_23415.pl | 11 +++++++++++ > installer/data/mysql/en/mandatory/sample_notices.yml | 4 ++-- > .../intranet-tmpl/prog/en/includes/renew_strings.inc | 2 +- > 3 files changed, 14 insertions(+), 3 deletions(-) > >diff --git a/installer/data/mysql/atomicupdate/bug_23415.pl b/installer/data/mysql/atomicupdate/bug_23415.pl >index f098a7b8da8..8d7cc1f8853 100755 >--- a/installer/data/mysql/atomicupdate/bug_23415.pl >+++ b/installer/data/mysql/atomicupdate/bug_23415.pl >@@ -49,5 +49,16 @@ return { > ); > > say $out "Added new system preference 'FineNoRenewalsBlockSelfCheckRenew'"; >+ >+ # Fix typo in notice templates: oweing -> owing >+ $dbh->do( >+ q{ >+ UPDATE letter >+ SET content = REPLACE(content, 'auto_too_much_oweing', 'auto_too_much_owing') >+ WHERE content LIKE '%auto_too_much_oweing%' >+ } >+ ); >+ >+ say $out "Fixed typo in notice templates: 'oweing' -> 'owing'"; > }, > }; >diff --git a/installer/data/mysql/en/mandatory/sample_notices.yml b/installer/data/mysql/en/mandatory/sample_notices.yml >index 69ff86f532b..79bdc7389b9 100644 >--- a/installer/data/mysql/en/mandatory/sample_notices.yml >+++ b/installer/data/mysql/en/mandatory/sample_notices.yml >@@ -2362,7 +2362,7 @@ tables: > - "You have overdue items." > - "[% ELSIF checkout.auto_renew_error == 'auto_too_late' %]" > - "It's too late to renew this item." >- - "[% ELSIF checkout.auto_renew_error == 'auto_too_much_oweing' %]" >+ - "[% ELSIF checkout.auto_renew_error == 'auto_too_much_owing' %]" > - "Your total unpaid fines are too high." > - "[% ELSIF checkout.auto_renew_error == 'too_unseen' %]" > - "This item must be renewed at the library." >@@ -2439,7 +2439,7 @@ tables: > - "You have overdue items." > - "[% ELSIF checkout.auto_renew_error == 'auto_too_late' %]" > - "It's too late to renew this item." >- - "[% ELSIF checkout.auto_renew_error == 'auto_too_much_oweing' %]" >+ - "[% ELSIF checkout.auto_renew_error == 'auto_too_much_owing' %]" > - "Your total unpaid fines are too high." > - "[% ELSIF checkout.auto_renew_error == 'too_unseen' %]" > - "This item must be renewed at the library." >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/renew_strings.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/renew_strings.inc >index 026cd7f011c..6c8e8fdae64 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/renew_strings.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/renew_strings.inc >@@ -15,7 +15,7 @@ > <span>Scheduled for automatic renewal and cannot be renewed because the patron's account has expired</span> > [% CASE 'auto_renew' %] > <span>Scheduled for automatic renewal</span> >-[% CASE 'auto_too_much_oweing' %] >+[% CASE 'auto_too_much_owing' %] > <span>Scheduled for automatic renewal and cannot be renewed because the patron has too many outstanding charges</span> > [% CASE 'on_reserve' %] > <span>On hold for another patron</span> >-- >2.53.0 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23415
:
92039
|
92541
|
98442
|
98634
|
98996
|
98997
|
105893
|
105894
|
108392
|
109871
|
109872
|
109876
|
109880
|
116919
|
116920
|
116921
|
116922
|
118175
|
118176
|
118177
|
118178
|
118183
|
119300
|
119301
|
119302
|
119303
|
121472
|
139670
|
139671
|
139672
|
139673
|
139674
|
146415
|
148198
|
148199
|
148200
|
148201
|
148202
|
152776
|
152777
|
152778
|
152779
|
152780
|
152781
|
154595
|
154596
|
154597
|
154598
|
154599
|
154600
|
158302
|
158303
|
158304
|
158305
|
158306
|
158307
|
161964
|
161965
|
161966
|
161967
|
161968
|
161969
|
162171
|
162172
|
162173
|
162174
|
162175
|
162176
|
162177
|
162178
|
162179
|
162180
|
171620
|
171621
|
171622
|
171623
|
171983
|
171984
|
171985
|
171986
|
172906
|
172907
|
172908
|
172909
|
172910
|
185270
|
185271
|
185272
|
185273
|
185274
|
185275
|
186014
|
188331
|
188332
|
188333
|
188334
|
188335
|
188336
|
188337
|
188338
|
188339
|
188340
|
188341
|
188342
|
188708
|
188709
|
188710
|
188711
|
188712
|
188713
|
188714
|
188715
|
188716
|
188717
|
188718
|
188719
|
188720
|
188738
|
188739
|
188740
|
188741
|
188742
|
188743
|
188744
|
188745
|
188746
|
188747
|
188748
|
188749
|
188750
|
188751
|
189721
|
189722
|
189723
|
189724
|
189725
|
189726
|
189727
|
189728
|
189729
|
189730
|
189731
|
189732
|
189733
|
189734
|
189735
|
189736
|
189737
|
189738
|
189739
|
189740
|
189741
|
189742
|
189743
|
189744
|
189745
|
189746
|
189747
|
189748
|
189749
|
189750
|
193077
|
193078
|
193079
|
193080
|
193081
|
193082
|
193083
|
193084
|
193085
|
193086
|
193087
|
193088
|
193089
|
193090
|
193091
| 193092