Bugzilla – Attachment 193136 Details for
Bug 40445
Point of Sale reconciliation input during daily summaries
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40445: (follow-up) Allow cashup with non-cash transactions
7d8c8f1.patch (text/plain), 3.78 KB, created by
Martin Renvoize (ashimema)
on 2026-02-13 17:21:40 UTC
(
hide
)
Description:
Bug 40445: (follow-up) Allow cashup with non-cash transactions
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2026-02-13 17:21:40 UTC
Size:
3.78 KB
patch
obsolete
>From 7d8c8f16f7da716186544e7382e799e3348d3e13 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@openfifth.co.uk> >Date: Mon, 12 Jan 2026 15:14:57 +0000 >Subject: [PATCH] Bug 40445: (follow-up) Allow cashup with non-cash > transactions > >Previously, the "Record cashup" buttons on both the register and >registers pages were disabled when there were zero CASH/SIP00 >transactions, even if other payment types (Card, etc.) had transactions. > >This was incorrect - cashup should be allowed as long as there are >ANY transactions, regardless of payment type. Staff still need to >record cashups even when all transactions were Card or other non-cash >payment methods. > >Changes: >- register.tt: Check total_transactions instead of total_bankable > to determine if cashup button should be enabled >- registers.tt: Check rtotal instead of rbankable for both checkbox > and button enable/disable logic > >Test plan: >1. Create transactions on a register using only Card payment type >2. Visit the register page - verify "Record cashup" button is enabled >3. Visit the registers page - verify the register checkbox is enabled > and "Record cashup" button is enabled >4. Perform a cashup - verify it completes successfully > >Signed-off-by: Jackie Usher <jackie.usher@westsussex.gov.uk> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/pos/registers.tt | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/pos/registers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/pos/registers.tt >index 8946faa30a0..19f820f9061 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/pos/registers.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/pos/registers.tt >@@ -157,13 +157,14 @@ > [% SET bankable = 0, ctotal = 0, dtotal = 0, cctotal = 0, cdtotal = 0 %] > [% FOREACH register IN registers %] > [% SET rbankable = ( register.outstanding_accountlines.total( payment_type => [ 'CASH', 'SIP00' ]) * -1 ) %] >+ [% SET rtotal = ( register.outstanding_accountlines.total() * -1 ) %] > <tr> > [% IF CAN_user_cash_management_cashup %] > <td> > [% IF register.cashup_in_progress %] > <input type="checkbox" class="register_checkbox" value="[% register.id | html %]" disabled title="Cashup in progress" /> >- [% ELSIF rbankable == 0 %] >- <input type="checkbox" class="register_checkbox" value="[% register.id | html %]" disabled title="No bankable transactions" /> >+ [% ELSIF rtotal == 0 %] >+ <input type="checkbox" class="register_checkbox" value="[% register.id | html %]" disabled title="No transactions" /> > [% ELSE %] > <input type="checkbox" class="register_checkbox" value="[% register.id | html %]" /> > [% END %] >@@ -223,7 +224,7 @@ > data-bankable="[% rbankable | $Price %]" > data-float="[% register.starting_float | $Price %]" > data-registerid="[% register.id | html %]" >- [% IF rbankable == 0 %]disabled title="No bankable transactions"[% END %] >+ [% IF rtotal == 0 %]disabled title="No transactions"[% END %] > ><i class="fa-solid fa-money-bill-1"></i> Record cashup</button > > > [% END %] >-- >2.53.0 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40445
:
185289
|
185290
|
185291
|
185292
|
185809
|
186636
|
186637
|
186638
|
186639
|
186640
|
186641
|
186642
|
186643
|
189333
|
189334
|
189335
|
189336
|
189337
|
189338
|
189339
|
189340
|
189341
|
189353
|
189354
|
189355
|
189356
|
189357
|
189358
|
189359
|
189360
|
189361
|
189362
|
189363
|
189364
|
189410
|
189411
|
189412
|
189413
|
189414
|
189415
|
189420
|
189421
|
189422
|
189423
|
189424
|
189425
|
189426
|
189427
|
189428
|
189429
|
189430
|
189476
|
189477
|
189478
|
189479
|
189480
|
189481
|
189482
|
190361
|
190362
|
190363
|
190364
|
190365
|
190366
|
190367
|
190368
|
190369
|
190370
|
190371
|
190372
|
190373
|
190374
|
190375
|
190376
|
190379
|
190380
|
190388
|
190389
|
190404
|
190405
|
190406
|
190407
|
190408
|
190409
|
190410
|
190411
|
190412
|
190413
|
190414
|
190415
|
191273
|
191274
|
191275
|
191276
|
191277
|
191278
|
191279
|
191280
|
191281
|
191282
|
191283
|
191284
|
191285
|
191286
|
191287
|
191288
|
193123
|
193124
|
193125
|
193126
|
193127
|
193128
|
193129
|
193130
|
193131
|
193132
|
193133
|
193134
|
193135
|
193136
|
193137
|
193138
|
193139
|
193140
|
193141
|
193180
|
193181
|
193182
|
193183