Bugzilla – Attachment 193142 Details for
Bug 38384
General fix for plugins breaking database transactions
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38384: (QA follow-up) Restore verbose option
Bug-38384-QA-follow-up-Restore-verbose-option.patch (text/plain), 1.81 KB, created by
Nick Clemens (kidclamp)
on 2026-02-13 17:40:14 UTC
(
hide
)
Description:
Bug 38384: (QA follow-up) Restore verbose option
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2026-02-13 17:40:14 UTC
Size:
1.81 KB
patch
obsolete
>From 3d1b935f69de99d976b38c0a362ef5d69798565e Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Fri, 13 Feb 2026 14:23:55 +0000 >Subject: [PATCH] Bug 38384: (QA follow-up) Restore verbose option > >--- > Koha/Plugins/Loader.pm | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > >diff --git a/Koha/Plugins/Loader.pm b/Koha/Plugins/Loader.pm >index d01d35c3eac..b471c8d6842 100644 >--- a/Koha/Plugins/Loader.pm >+++ b/Koha/Plugins/Loader.pm >@@ -60,12 +60,14 @@ if plugins are not available or none are enabled. > =cut > > sub get_enabled_plugins { >- my ($class) = @_; >+ my ( $class, $params ) = @_; > > my $cache_key = 'enabled_plugins'; > my $cached = Koha::Cache::Memory::Lite->get_from_cache($cache_key); > return @$cached if $cached; > >+ my $verbose = $params->{verbose} // 0; >+ > # Check if plugin_data table exists (using DBH for early init safety) > my $dbh = eval { Koha::Database->dbh }; > return unless $dbh; >@@ -101,12 +103,14 @@ sub get_enabled_plugins { > if ( eval { Koha::Plugins->can('can_load') } ) { > > # Use Koha::Plugins::can_load if it exists (might be mocked in tests) >- $can_load_result = eval { Koha::Plugins::can_load( modules => { $plugin_class => undef }, nocache => 1 ) }; >+ $can_load_result = eval { >+ Koha::Plugins::can_load( modules => { $plugin_class => undef }, verbose => $verbose, nocache => 1 ); >+ }; > } > if ( !defined $can_load_result ) { > > # Fall back to Module::Load::Conditional >- $can_load_result = can_load( modules => { $plugin_class => undef }, nocache => 1 ); >+ $can_load_result = can_load( modules => { $plugin_class => undef }, verbose => $verbose, nocache => 1 ); > } > > next unless $can_load_result; >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38384
:
174150
|
174264
|
174265
|
174280
|
174282
|
189636
|
189637
|
189638
|
189639
|
189640
|
190514
|
190515
|
190516
|
190517
|
191860
|
192119
|
192628
|
192629
|
192630
|
192631
|
192632
|
192633
|
192662
|
192663
|
192664
|
192665
|
192666
|
192667
|
193142
|
193143
|
193144
|
193171
|
193172
|
193173
|
193174
|
193175
|
193176
|
193177
|
193178
|
193179