Bugzilla – Attachment 193184 Details for
Bug 41857
Suggestions table actions broken Update manager and Delete selected actions)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41857: Remove suggestion
Bug-41857-Remove-suggestion.patch (text/plain), 1.89 KB, created by
Pedro Amorim
on 2026-02-16 11:59:26 UTC
(
hide
)
Description:
Bug 41857: Remove suggestion
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2026-02-16 11:59:26 UTC
Size:
1.89 KB
patch
obsolete
>From af4d4d2042b62bdf57bd0bf39fcfa11a5e9f07c4 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@openfifth.co.uk> >Date: Mon, 16 Feb 2026 11:55:44 +0000 >Subject: [PATCH] Bug 41857: Remove suggestion > >I don't understand why we need this here, but it seems to be picking up a leftover suggestion from a previous loop. >This code itself is not within a loop, so it doesnt have the hashref containing suggestiontype from suggestion.pl. >It's trying to access suggestiontype from Koha::Suggestion which causes an explosion >--- > .../intranet-tmpl/prog/en/modules/suggestion/suggestion.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >index ad235d56fac..8a59835b82f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >@@ -1064,8 +1064,8 @@ > <fieldset class="collapse suggestion_information"> > <ol> > <li> >- <label for="STATUS-[% suggestion.suggestiontype | html %]"> Status:</label> >- <select name="STATUS" id="STATUS-[% suggestion.suggestiontype | html %]"> >+ <label for="STATUS"> Status:</label> >+ <select name="STATUS" id="STATUS"> > <option value="">Any</option> > [% IF (statusselected_ASKED ) %] > <option value="ASKED" selected="selected">Pending</option> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41857
:
193184
|
193185
|
193256
|
193268
|
193269
|
193270