Bugzilla – Attachment 193208 Details for
Bug 40817
Holds charges should be accessible from Holds
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40817: Fix C3 MRO compilation errors in child classes
840da39.patch (text/plain), 1.39 KB, created by
Martin Renvoize (ashimema)
on 2026-02-16 12:49:43 UTC
(
hide
)
Description:
Bug 40817: Fix C3 MRO compilation errors in child classes
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2026-02-16 12:49:43 UTC
Size:
1.39 KB
patch
obsolete
>From 840da396f3a239928789ef89fd02c45859965be8 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@openfifth.co.uk> >Date: Mon, 16 Feb 2026 12:46:32 +0000 >Subject: [PATCH] Bug 40817: Fix C3 MRO compilation errors in child classes > >Explicitly load parent classes before inheritance declarations to resolve >C3 method resolution order errors that occurred during QA syntax checking. > >Modern::Perl enables C3 MRO by default, and the base pragma needs the >parent class to be fully loaded before establishing inheritance. Adding >explicit 'use Parent::Class;' statements before 'use base qw(Parent::Class);' >ensures proper C3 linearization during compile-time checks. > >This resolves QA script failures while maintaining all existing functionality. >--- > Koha/Account/Debit.pm | 1 + > Koha/Old/Hold.pm | 1 + > 2 files changed, 2 insertions(+) > >diff --git a/Koha/Account/Debit.pm b/Koha/Account/Debit.pm >index a9df10be401..d92e8d100f4 100644 >--- a/Koha/Account/Debit.pm >+++ b/Koha/Account/Debit.pm >@@ -19,6 +19,7 @@ package Koha::Account::Debit; > > use Modern::Perl; > >+use Koha::Account::Line; > use base qw(Koha::Account::Line); > > =head1 NAME >diff --git a/Koha/Old/Hold.pm b/Koha/Old/Hold.pm >index fcb2348655e..b1497d7905c 100644 >--- a/Koha/Old/Hold.pm >+++ b/Koha/Old/Hold.pm >@@ -19,6 +19,7 @@ package Koha::Old::Hold; > > use Modern::Perl; > >+use Koha::Hold; > use base qw(Koha::Hold); > > use C4::Context; >-- >2.53.0 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40817
:
186476
|
186477
|
186478
|
186479
|
186480
|
186481
|
189610
|
189611
|
189612
|
189613
|
189614
|
189615
|
193202
|
193203
|
193204
|
193205
|
193206
|
193207
| 193208