Bugzilla – Attachment 19327 Details for
Bug 10519
Suggestions: 'Organize by' and correct display of tab descriptions broken
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10519: Fix display of tab for ordered suggestions
Bug-10519-Fix-display-of-tab-for-ordered-suggestio.patch (text/plain), 1.27 KB, created by
Katrin Fischer
on 2013-07-01 21:21:30 UTC
(
hide
)
Description:
Bug 10519: Fix display of tab for ordered suggestions
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2013-07-01 21:21:30 UTC
Size:
1.27 KB
patch
obsolete
>From 736d1a402d3e6c2f487c1703ab2a589ddc6e11b3 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <Katrin.Fischer.83@web.de> >Date: Mon, 1 Jul 2013 23:17:58 +0200 >Subject: [PATCH] Bug 10519: Fix display of tab for ordered suggestions > >Adds 2 more valid status to a check to make the description on the >tab for 'Ordered' and 'Available' suggestions show up correctly. > >To test: >- Make 2 suggestions. >- Accept both and order them in acquisitions. >- Receive one of them. >- Use the 'Organize by' filter with 'Status' >- Verify status descriptions in the tabs show up correctly. >--- > suggestion/suggestion.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/suggestion/suggestion.pl b/suggestion/suggestion.pl >index fd9a9c2..6a32a48 100755 >--- a/suggestion/suggestion.pl >+++ b/suggestion/suggestion.pl >@@ -58,7 +58,7 @@ sub Init{ > > sub GetCriteriumDesc{ > my ($criteriumvalue,$displayby)=@_; >- unless ( grep { /$criteriumvalue/ } qw(ASKED ACCEPTED REJECTED CHECKED) ) { >+ unless ( grep { /$criteriumvalue/ } qw(ASKED ACCEPTED REJECTED CHECKED ORDERED AVAILABLE) ) { > return GetAuthorisedValueByCode('SUGGEST_STATUS', $criteriumvalue ) || "Unknown"; > } > return ($criteriumvalue eq 'ASKED'?"Pending":ucfirst(lc( $criteriumvalue))) if ($displayby =~/status/i); >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10519
:
19300
|
19327
|
19340
|
19341
|
19355
|
19356
|
19364
|
28763
|
28850
|
28851
|
28852
|
29598
|
29599
|
29686