Bugzilla – Attachment 193297 Details for
Bug 38365
Add Content-Security-Policy HTTP header to HTML responses
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38365: Fix no-op //= operator on variable declarations
Bug-38365-Fix-no-op--operator-on-variable-declarat.patch (text/plain), 1.72 KB, created by
David Cook
on 2026-02-17 05:52:53 UTC
(
hide
)
Description:
Bug 38365: Fix no-op //= operator on variable declarations
Filename:
MIME Type:
Creator:
David Cook
Created:
2026-02-17 05:52:53 UTC
Size:
1.72 KB
patch
obsolete
>From 571cad1e2691c68d885a199f917580ad6450aed6 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@openfifth.co.uk> >Date: Mon, 2 Feb 2026 10:02:23 +0000 >Subject: [PATCH] Bug 38365: Fix no-op //= operator on variable declarations > >The //= (defined-or assignment) operator on a freshly declared >variable is a no-op since the variable is always undef at that >point. Replace with simple = assignment. > >Affects header_name(), header_value(), and is_enabled() methods. > >Signed-off-by: David Cook <dcook@prosentient.com.au> >Signed-off-by: Lari Taskula <lari.taskula@hypernova.fi> >--- > Koha/ContentSecurityPolicy.pm | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/Koha/ContentSecurityPolicy.pm b/Koha/ContentSecurityPolicy.pm >index 79c8bc99ca1..de17672e813 100644 >--- a/Koha/ContentSecurityPolicy.pm >+++ b/Koha/ContentSecurityPolicy.pm >@@ -84,7 +84,7 @@ sub new { > sub header_name { > my ( $self, $args ) = @_; > >- my $interface //= $args->{interface} || C4::Context->interface; >+ my $interface = $args->{interface} || C4::Context->interface; > > my $conf_csp = $self->{config}->get('content_security_policy'); > >@@ -119,7 +119,7 @@ sub header_name { > sub header_value { > my ( $self, $args ) = @_; > >- my $interface //= $args->{interface} || C4::Context->interface; >+ my $interface = $args->{interface} || C4::Context->interface; > > my $conf_csp = $self->{config}->get('content_security_policy'); > >@@ -153,7 +153,7 @@ sub header_value { > > sub is_enabled { > my ( $self, $args ) = @_; >- my $interface //= $args->{interface} || C4::Context->interface; >+ my $interface = $args->{interface} || C4::Context->interface; > > my $conf_csp = $self->{config}->get('content_security_policy'); > >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38365
:
174054
|
188487
|
188488
|
188489
|
188490
|
188491
|
188733
|
188734
|
188735
|
188736
|
188737
|
188881
|
188882
|
189465
|
189466
|
189467
|
189468
|
189469
|
189470
|
189471
|
189472
|
191618
|
191619
|
191620
|
191621
|
191622
|
191623
|
191660
|
191661
|
191662
|
191663
|
191664
|
191665
|
191666
|
191667
|
191668
|
192294
|
192295
|
192296
|
192297
|
192298
|
192299
|
192300
|
192301
|
192302
|
192303
|
192304
|
192305
|
192306
|
192412
|
192413
|
192414
|
192415
|
192416
|
192417
|
192418
|
192419
|
192420
|
192421
|
192422
|
192423
|
192424
|
192425
|
192426
|
192427
|
192428
|
192429
|
192524
|
192535
|
192536
|
192537
|
192553
|
192554
|
192555
|
192556
|
192557
|
192558
|
192559
|
192560
|
192561
|
192562
|
192563
|
192564
|
192565
|
192566
|
192567
|
192568
|
192569
|
192570
|
192571
|
192572
|
192573
|
192574
|
192684
|
192685
|
192686
|
192691
|
192692
|
192693
|
192694
|
192695
|
192696
|
192697
|
192698
|
192699
|
192700
|
192701
|
192702
|
192703
|
192704
|
192705
|
192706
|
192707
|
192708
|
192709
|
192738
|
192843
|
192844
|
192934
|
192935
|
192936
|
192937
|
193288
|
193289
|
193290
|
193291
|
193292
|
193293
|
193294
|
193295
|
193296
|
193297
|
193298
|
193299
|
193300
|
193301
|
193302
|
193303
|
193304
|
193305
|
193306
|
193307
|
193308
|
193309
|
193310
|
193311
|
193312
|
193335
|
193705
|
193706
|
193707
|
193708
|
193709
|
193710
|
193711
|
193712
|
193713
|
193714
|
193941
|
193942
|
193943
|
193944
|
193945
|
193946
|
193947
|
193948
|
193949
|
193950
|
193951
|
193952
|
193953
|
193954
|
193955
|
193956
|
193957
|
193958
|
193959
|
193960
|
193961
|
193962
|
193963
|
193964
|
193965
|
193966
|
193967
|
193968