Bugzilla – Attachment 193315 Details for
Bug 41857
Suggestions table actions broken Update manager and Delete selected actions)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41857: Only find singly suggestion by id if 'edit_form'
1fdb967.patch (text/plain), 1.12 KB, created by
Jonathan Druart
on 2026-02-17 08:15:22 UTC
(
hide
)
Description:
Bug 41857: Only find singly suggestion by id if 'edit_form'
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2026-02-17 08:15:22 UTC
Size:
1.12 KB
patch
obsolete
>From 1fdb967a69cce0d47dc0e905a75483ccb73dc64c Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@openfifth.co.uk> >Date: Mon, 16 Feb 2026 15:09:53 +0000 >Subject: [PATCH] Bug 41857: Only find singly suggestion by id if 'edit_form' > >All ops that iterate on editsuggestions can potentially have multiple suggestionid and don't need stored_suggestion >cud-update_status >cud-delete >cud-archive >cud-unarchive >cud-update_itemtype >cud-update_manager > >I'm unsure if op = 'else' should also be included with edit_form > >Signed-off-by: David Nind <david@davidnind.com> >--- > suggestion/suggestion.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/suggestion/suggestion.pl b/suggestion/suggestion.pl >index 93d8f199074..5e5689002ff 100755 >--- a/suggestion/suggestion.pl >+++ b/suggestion/suggestion.pl >@@ -101,7 +101,7 @@ my $reasonsloop = GetAuthorisedValues("SUGGEST"); > > my $suggestion_ref = { $input->Vars }; > my $stored_suggestion; >-unless ( $op eq "cud-update_status" ) { >+if ( $op eq "edit_form" ) { > $stored_suggestion = Koha::Suggestions->find( $input->param('suggestionid') ) if $input->param('suggestionid'); > } > >-- >2.43.0 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41857
:
193184
|
193185
|
193256
|
193268
|
193269
|
193270
|
193313
|
193314
| 193315