Attachment 19335 Details for Bug 10215 – Bug 10215 - Increase the size of opacnote and librariannote for table subscriptionhistory

[patch] Bug 10215 - Increase the size of opacnote and librariannote for table subscriptionhistory

Bug-10215---Increase-the-size-of-opacnote-and-libr.patch (text/plain), 3.38 KB, created by Kyle M Hall (khall) on 2013-07-02 11:34:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2013-07-02 11:34:28 UTC

Size: 3.38 KB

patch

obsolete

>From 5850834bf360cf63245259449bcf9c4a7b5c88a2 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Tue, 7 May 2013 12:49:03 -0400
>Subject: [PATCH] Bug 10215 - Increase the size of opacnote and librariannote for table subscriptionhistory
>
>We have librarians that are regularly hitting the maximum number of
>characters for the note fields in subscription history. They would like
>to be able to store at least 1000 characters here. Converting the
>varchar(150) to text should do it.
>
>Test Plan:
>1) Apply this patch
>2) Run updatedatabase.pl
>3) Add public and private notes to a subscription history entry
>   where each note is greater than 150 characters.
>4) Save and view the notes, the notes should not be truncated.
>---
> C4/Serials.pm                          |    6 ++++++
> installer/data/mysql/kohastructure.sql |    4 ++--
> installer/data/mysql/updatedatabase.pl |    8 ++++++++
> 3 files changed, 16 insertions(+), 2 deletions(-)
>
>diff --git a/C4/Serials.pm b/C4/Serials.pm
>index 76d3fc7..b9fcd98 100644
>--- a/C4/Serials.pm
>+++ b/C4/Serials.pm
>@@ -483,6 +483,7 @@ sub GetSubscriptionsFromBiblionumber {
>         $subs->{startdate}     = format_date( $subs->{startdate} );
>         $subs->{histstartdate} = format_date( $subs->{histstartdate} );
>         $subs->{histenddate}   = format_date( $subs->{histenddate} );
>+        $subs->{opacnote} ||= q{};
>         $subs->{opacnote}     =~ s/\n/\<br\/\>/g;
>         $subs->{missinglist}  =~ s/\n/\<br\/\>/g;
>         $subs->{recievedlist} =~ s/\n/\<br\/\>/g;
>@@ -1081,6 +1082,11 @@ returns the number of rows affected
> 
> sub ModSubscriptionHistory {
>     my ( $subscriptionid, $histstartdate, $enddate, $recievedlist, $missinglist, $opacnote, $librariannote ) = @_;
>+
>+    $recievedlist ||= q{};
>+    $missinglist  ||= q{};
>+    $opacnote     ||= q{};
>+
>     my $dbh   = C4::Context->dbh;
>     my $query = "UPDATE subscriptionhistory 
>                     SET histstartdate=?,histenddate=?,recievedlist=?,missinglist=?,opacnote=?,librariannote=?
>diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql
>index d7eebdd..4a85892 100644
>--- a/installer/data/mysql/kohastructure.sql
>+++ b/installer/data/mysql/kohastructure.sql
>@@ -2046,8 +2046,8 @@ CREATE TABLE `subscriptionhistory` (
>   `histenddate` date default NULL,
>   `missinglist` longtext NOT NULL,
>   `recievedlist` longtext NOT NULL,
>-  `opacnote` varchar(150) NOT NULL default '',
>-  `librariannote` varchar(150) NOT NULL default '',
>+  `opacnote` text NULL,
>+  `librariannote` text NULL,
>   PRIMARY KEY  (`subscriptionid`),
>   KEY `biblionumber` (`biblionumber`)
> ) ENGINE=InnoDB DEFAULT CHARSET=utf8;
>diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl
>index 5963d24..2e8d9e0 100755
>--- a/installer/data/mysql/updatedatabase.pl
>+++ b/installer/data/mysql/updatedatabase.pl
>@@ -7010,6 +7010,14 @@ CREATE TABLE IF NOT EXISTS borrower_files (
>     SetVersion($DBversion);
> }
> 
>+$DBversion = "3.13.00.XXX";
>+if ( CheckVersion($DBversion) ) {
>+    $dbh->do(q{ALTER TABLE subscriptionhistory CHANGE opacnote opacnote TEXT NULL});
>+    $dbh->do(q{ALTER TABLE subscriptionhistory CHANGE librariannote librariannote TEXT NULL});
>+    print "Upgrade to $DBversion done (Bug 10215 - Increase the size of opacnote and librariannote for table subscriptionhistory)\n";
>+    SetVersion ($DBversion);
>+}
>+
> =head1 FUNCTIONS
> 
> =head2 TableExists($table)
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 10215: 17998 | 17999 | 19247 | 19335 | 85395 | 85400 | 87705 | 90323 | 90324 | 90325 | 90355 | 90356 | 90357