Bugzilla – Attachment 193366 Details for
Bug 41861
ILL request cost and price paid don't show if 0
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41861: Update how cost and price_paid show
f35fcea.patch (text/plain), 2.58 KB, created by
David Nind
on 2026-02-18 21:50:28 UTC
(
hide
)
Description:
Bug 41861: Update how cost and price_paid show
Filename:
MIME Type:
Creator:
David Nind
Created:
2026-02-18 21:50:28 UTC
Size:
2.58 KB
patch
obsolete
>From f35fceaf96446e025d6c0f544d0c8941fc552b66 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@openfifth.co.uk> >Date: Tue, 17 Feb 2026 10:20:11 +0000 >Subject: [PATCH] Bug 41861: Update how cost and price_paid show > >1) Enabled ILLModule >2) Create a new ILL request, set a title, '42' for cardnumber and any library: ><staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard >3) (k-t-d required, cost is not editable in UI, but backends may set it) Run the following query: >koha-mysql kohadev >update illrequests set cost = 1; >4) Notice cost shows, now run the same but set to 0: >update illrequests set cost = 1; >5) Notice it doesn't show. >6) Apply patch. Refresh. Notice is shows '0' now. >--- > koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt >index 237f3392f7..87b13cfd5e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt >@@ -434,7 +434,7 @@ > </li> > <li class="cost"> > <label class="cost">Cost:</label> >- [% IF request.cost %][% request.cost | $Price %][% ELSE %]<span>N/A</span>[% END %] >+ [% IF request.cost.defined %][% request.cost | $Price %][% ELSE %]<span>N/A</span>[% END %] > </li> > <li class="price_paid"> > <label class="price_paid">Price paid:</label> >@@ -717,13 +717,13 @@ > [% type_disclaimer_date | $KohaDates with_hours => 1 %] > </li> > [% END %] >- [% IF request.cost %] >+ [% IF request.cost.defined %] > <li class="cost"> > <span class="label cost">Cost:</span> > [% request.cost | $Price %] > </li> > [% END %] >- [% IF request.price_paid %] >+ [% IF request.price_paid.defined %] > <li class="price_paid"> > <span class="label price_paid">Price paid:</span> > [% request.price_paid | $Price %] >-- >2.39.5 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41861
:
193316
|
193366
|
193486