Bugzilla – Attachment 193400 Details for
Bug 38924
Introduce an organization level loan 'Quota' system for Koha
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38924: Add quotas permissions
Bug-38924-Add-quotas-permissions.patch (text/plain), 4.78 KB, created by
Jacob O'Mara
on 2026-02-19 12:09:17 UTC
(
hide
)
Description:
Bug 38924: Add quotas permissions
Filename:
MIME Type:
Creator:
Jacob O'Mara
Created:
2026-02-19 12:09:17 UTC
Size:
4.78 KB
patch
obsolete
>From 24e2b8554c19041d59beb8d5b89dbfdd4e039475 Mon Sep 17 00:00:00 2001 >From: Jacob O'Mara <jacobomara901@gmail.com> >Date: Thu, 30 Jan 2025 10:37:08 +0000 >Subject: [PATCH] Bug 38924: Add quotas permissions > >This patch adds the new quotas permissions to the system >--- > .../mysql/atomicupdate/bug_38924-patron_quotas.pl | 11 +++++++++-- > installer/data/mysql/mandatory/userpermissions.sql | 2 ++ > .../intranet-tmpl/prog/en/includes/permissions.inc | 6 ++++++ > t/Koha/Auth/Permissions.t | 2 ++ > 4 files changed, 19 insertions(+), 2 deletions(-) > >diff --git a/installer/data/mysql/atomicupdate/bug_38924-patron_quotas.pl b/installer/data/mysql/atomicupdate/bug_38924-patron_quotas.pl >index 848fe85c668..a6531fbb1ab 100755 >--- a/installer/data/mysql/atomicupdate/bug_38924-patron_quotas.pl >+++ b/installer/data/mysql/atomicupdate/bug_38924-patron_quotas.pl >@@ -3,7 +3,7 @@ use Koha::Installer::Output qw(say_warning say_success say_info); > > return { > bug_number => "38924", >- description => "Add patron quota table", >+ description => "Add patron quota table and permissions", > up => sub { > my ($args) = @_; > my ( $dbh, $out ) = @$args{qw(dbh out)}; >@@ -25,7 +25,14 @@ return { > ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci; > } > ); >- say_success( $out, "Patron quota table created successfully" ); >+ >+ $dbh->do(q{ >+ INSERT IGNORE INTO permissions (module_bit, code, description) VALUES >+ (4, 'manage_borrower_quotas', 'Manage patron quotas'), >+ (4, 'view_borrower_quotas', 'View patron quotas') >+ }); >+ >+ say_success( $out, "Patron quota table and permissions created successfully" ); > } else { > say_info( $out, "Patron quota table already exists" ); > } >diff --git a/installer/data/mysql/mandatory/userpermissions.sql b/installer/data/mysql/mandatory/userpermissions.sql >index 10b8607c47d..ab1f8f44588 100644 >--- a/installer/data/mysql/mandatory/userpermissions.sql >+++ b/installer/data/mysql/mandatory/userpermissions.sql >@@ -50,8 +50,10 @@ INSERT INTO permissions (module_bit, code, description) VALUES > ( 4, 'edit_borrowers', 'Add, modify and view patron information'), > ( 4, 'list_borrowers', 'Search, list and view patrons'), > ( 4, 'merge_borrowers', 'Merge patrons'), >+ ( 4, 'manage_borrower_quotas', 'Manage patron quotas'), > ( 4, 'send_messages_to_borrowers', 'Send messages to patrons'), > ( 4, 'view_borrower_infos_from_any_libraries', 'View patron infos from any libraries'), >+ ( 4, 'view_borrower_quotas', 'View patron quotas'), > ( 4, 'view_checkout_history', 'View checkout history'), > ( 4, 'view_holds_history', 'View holds history'), > ( 6, 'place_holds', 'Place holds for patrons'), >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc >index 535d6da6914..b6c4f5faddd 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc >@@ -574,6 +574,12 @@ > [%- CASE 'marc_order_manage' -%] > <span class="sub_permission marc_order_manage_subpermission"> Manage MARC ordering </span> > <span class="permissioncode">([% name | html %])</span> >+ [%- CASE 'view_borrower_quotas' -%] >+ <span class="sub_permission view_borrower_quotas_subpermission"> View patron quotas </span> >+ <span class="permissioncode">([% name | html %])</span> >+ [%- CASE 'manage_borrower_quotas' -%] >+ <span class="sub_permission manage_borrower_quotas_subpermission"> Manage patron quotas </span> >+ <span class="permissioncode">([% name | html %])</span> > [%- CASE 'reopen_closed_invoices' -%] > <span class="sub_permission reopen_closed_invoices_subpermission"> Reopen closed invoices </span> > <span class="permissioncode">([% name | html %])</span> >diff --git a/t/Koha/Auth/Permissions.t b/t/Koha/Auth/Permissions.t >index 32081bc70f4..439863a584b 100755 >--- a/t/Koha/Auth/Permissions.t >+++ b/t/Koha/Auth/Permissions.t >@@ -131,6 +131,8 @@ subtest 'superlibrarian tests' => sub { > 'CAN_user_borrowers_edit_borrowers' => 1, > 'CAN_user_borrowers_list_borrowers' => 1, > 'CAN_user_borrowers_api_validate_password' => 1, >+ 'CAN_user_borrowers_manage_borrower_quotas' => 1, >+ 'CAN_user_borrowers_view_borrower_quotas' => 1, > 'CAN_user_borrowers_view_borrower_infos_from_any_libraries' => 1, > 'CAN_user_borrowers_view_checkout_history' => 1, > 'CAN_user_borrowers_view_holds_history' => 1, >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38924
:
178582
|
178583
|
178584
|
178585
|
178586
|
178587
|
178588
|
178589
|
178590
|
178591
|
178592
|
178593
|
178594
|
178595
|
178596
|
178597
|
178598
|
178599
|
178600
|
178601
|
178602
|
178603
|
178604
|
178605
|
178606
|
178607
|
178608
|
185631
|
185632
|
185633
|
185634
|
185635
|
185636
|
185637
|
185638
|
185639
|
185640
|
185641
|
185642
|
185643
|
185644
|
185645
|
185646
|
185647
|
185648
|
185649
|
185650
|
185651
|
185652
|
185653
|
185654
|
185655
|
185656
|
185657
|
185675
|
185676
|
185677
|
185678
|
185679
|
185680
|
185681
|
185682
|
185683
|
185684
|
185685
|
185686
|
185687
|
185688
|
185689
|
185690
|
185691
|
185692
|
185693
|
185694
|
185695
|
185696
|
185697
|
185698
|
185699
|
185700
|
185701
|
185702
|
189266
|
189267
|
189268
|
189269
|
189270
|
189271
|
189272
|
189273
|
189274
|
189275
|
189276
|
189277
|
189278
|
189279
|
189280
|
189281
|
189282
|
189283
|
189284
|
189285
|
189286
|
189287
|
189288
|
189289
|
189290
|
189291
|
189292
|
193377
|
193378
|
193379
|
193380
|
193381
|
193382
|
193383
|
193384
|
193385
|
193386
|
193387
|
193388
|
193389
|
193390
|
193391
|
193392
|
193393
|
193394
|
193395
|
193396
|
193397
|
193398
|
193399
|
193400
|
193401
|
193402
|
193403
|
193404
|
193405
|
193406
|
193407
|
193408
|
193409
|
193410
|
193411
|
193412
|
193413
|
193414
|
193415
|
193416
|
193417
|
193418
|
193419
|
193420
|
193421
|
193422
|
193423
|
193424
|
193425
|
193426
|
193427
|
193428
|
193429
|
193430
|
193431
|
193432
|
193433
|
193434
|
193435
|
193436
|
193437
|
193438
|
193439
|
193440
|
193441
|
193442
|
193443
|
193444
|
193445
|
193446
|
193447
|
193448
|
193449
|
193450
|
193451
|
193452
|
193453
|
193454
|
193455
|
193456
|
193457
|
193458
|
193459
|
193460
|
193547
|
193548
|
193549
|
193550
|
193551
|
193552
|
193553
|
193554
|
193555
|
193556
|
193557
|
193558
|
193559
|
193560
|
193561
|
193562
|
193563
|
193564
|
193565
|
193566
|
193567
|
193568
|
193569
|
193570
|
193571
|
193572
|
193573
|
193574
|
193575
|
193576
|
193577