Bugzilla – Attachment 193506 Details for
Bug 36752
Remove TODO about missing summary info in the SIP2 code
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36752: Remove confusing TODOs
Bug-36752-Remove-confusing-TODOs.patch (text/plain), 1.46 KB, created by
Marcel de Rooy
on 2026-02-20 10:11:15 UTC
(
hide
)
Description:
Bug 36752: Remove confusing TODOs
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2026-02-20 10:11:15 UTC
Size:
1.46 KB
patch
obsolete
>From 34b4648e9a949b50872a735fa5e4e4946cda6fb1 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 20 Feb 2026 11:02:14 +0100 >Subject: [PATCH] Bug 36752: Remove confusing TODOs >Content-Type: text/plain; charset=utf-8 > >As Jan Kissig correctly mentioned on the BZ report, the various >summary info on charged items etc. are included. >This is done via the summary_info sub. > >Note that the TODOs about > BZ FID_HOLD_ITEMS_LMT > CA FID_OVERDUE_ITEMS_LMT > CB FID_CHARGED_ITEMS_LMT >are still valid. This is not included yet. > >Test plan. >Since we are just removing comments, read the code. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > C4/SIP/Sip/MsgType.pm | 7 ------- > 1 file changed, 7 deletions(-) > >diff --git a/C4/SIP/Sip/MsgType.pm b/C4/SIP/Sip/MsgType.pm >index 37cb7d1a7e..e2ed6de3f7 100644 >--- a/C4/SIP/Sip/MsgType.pm >+++ b/C4/SIP/Sip/MsgType.pm >@@ -1124,13 +1124,6 @@ sub handle_patron_info { > $resp .= maybe_add( FID_FEE_AMT, $patron->fee_amount, $server ); > $resp .= add_field( FID_FEE_LMT, $patron->fee_limit, $server ); > >- # TODO: zero or more item details for 2.0 can go here: >- # hold_items >- # overdue_items >- # charged_items >- # fine_items >- # recall_items >- > $resp .= summary_info( $ils, $patron, $summary, $start, $end, $server ); > > $resp .= maybe_add( FID_HOME_ADDR, $patron->address, $server ); >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36752
:
193506
|
193542