Bugzilla – Attachment 193577 Details for
Bug 38924
Introduce an organization level loan 'Quota' system for Koha
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38924: (follow-up) Exclude QUOTA_SELECT from session remember
Bug-38924-follow-up-Exclude-QUOTASELECT-from-sessi.patch (text/plain), 4.39 KB, created by
Jacob O'Mara
on 2026-02-20 13:41:39 UTC
(
hide
)
Description:
Bug 38924: (follow-up) Exclude QUOTA_SELECT from session remember
Filename:
MIME Type:
Creator:
Jacob O'Mara
Created:
2026-02-20 13:41:39 UTC
Size:
4.39 KB
patch
obsolete
>From 75b54eca726a69cfa649c7c25e929fc97e67255d Mon Sep 17 00:00:00 2001 >From: Jacob O'Mara <Jacob.omara@openfifth.co.uk> >Date: Fri, 20 Feb 2026 13:36:38 +0000 >Subject: [PATCH] Bug 38924: (follow-up) Exclude QUOTA_SELECT from session > remember > >Prevents quota selection from being stored in or skipped by the >session confirmation cookie. Hides the remember checkbox when quota >is the only confirmation shown. >--- > circ/circulation.pl | 4 +++- > .../prog/en/modules/circ/circulation.tt | 20 +++++++++++-------- > 2 files changed, 15 insertions(+), 9 deletions(-) > >diff --git a/circ/circulation.pl b/circ/circulation.pl >index ed4831fc1c8..f017af8d6d7 100755 >--- a/circ/circulation.pl >+++ b/circ/circulation.pl >@@ -523,6 +523,7 @@ if ( @$barcodes && $op eq 'cud-checkout' ) { > next > if $patron_match > && scalar(@conf_keys) > 0 >+ && $needsconfirmation_key ne 'QUOTA_SELECT' > && grep( { $needsconfirmation_key eq $_ } @conf_keys ); > > $template_params->{$needsconfirmation_key} = $needsconfirmation->{$needsconfirmation_key}; >@@ -530,7 +531,8 @@ if ( @$barcodes && $op eq 'cud-checkout' ) { > $template_params->{getBarcodeMessageIteminfo} = $item->barcode; > $template_params->{NEEDSCONFIRMATION} = 1; > $confirm_required = 1; >- push( @{ $template_params->{sessionConfirmationKeys} }, $needsconfirmation_key ); >+ push( @{ $template_params->{sessionConfirmationKeys} }, $needsconfirmation_key ) >+ unless $needsconfirmation_key eq 'QUOTA_SELECT'; > } > } > unless ($confirm_required) { >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >index 764a5634b23..ed75514c75e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >@@ -468,10 +468,12 @@ > [% IF ( RENEW_ISSUE ) %] > <button type="submit" class="btn btn-default approve" accesskey="y"><i class="fa fa-check"></i> Yes, renew (Y)</button> > [% ELSE %] >- <p> >- <label for="patron_session_confirmation">Remember for the session for this patron</label> >- <input type="checkbox" id="patron_session_confirmation" name="patron_session_confirmation" /> >- </p> >+ [% IF sessionConfirmationKeys.size %] >+ <p> >+ <label for="patron_session_confirmation">Remember for the session for this patron</label> >+ <input type="checkbox" id="patron_session_confirmation" name="patron_session_confirmation" /> >+ </p> >+ [% END %] > <button type="submit" class="btn btn-default approve" accesskey="y"><i class="fa fa-check"></i> Yes, check out (Y)</button> > [% END %] > >@@ -502,10 +504,12 @@ > [% IF ( RENEW_ISSUE ) %] > <button type="submit" class="btn btn-default approve" accesskey="y"><i class="fa fa-check"></i> Yes, renew (Y)</button> > [% ELSE %] >- <p> >- <label for="patron_session_confirmation">Remember for the session for this patron</label> >- <input type="checkbox" id="patron_session_confirmation" name="patron_session_confirmation" /> >- </p> >+ [% IF sessionConfirmationKeys.size %] >+ <p> >+ <label for="patron_session_confirmation">Remember for the session for this patron</label> >+ <input type="checkbox" id="patron_session_confirmation" name="patron_session_confirmation" /> >+ </p> >+ [% END %] > <button type="submit" class="btn btn-default approve" accesskey="y"><i class="fa fa-check"></i> Yes, check out (Y)</button> > [% END %] > >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38924
:
178582
|
178583
|
178584
|
178585
|
178586
|
178587
|
178588
|
178589
|
178590
|
178591
|
178592
|
178593
|
178594
|
178595
|
178596
|
178597
|
178598
|
178599
|
178600
|
178601
|
178602
|
178603
|
178604
|
178605
|
178606
|
178607
|
178608
|
185631
|
185632
|
185633
|
185634
|
185635
|
185636
|
185637
|
185638
|
185639
|
185640
|
185641
|
185642
|
185643
|
185644
|
185645
|
185646
|
185647
|
185648
|
185649
|
185650
|
185651
|
185652
|
185653
|
185654
|
185655
|
185656
|
185657
|
185675
|
185676
|
185677
|
185678
|
185679
|
185680
|
185681
|
185682
|
185683
|
185684
|
185685
|
185686
|
185687
|
185688
|
185689
|
185690
|
185691
|
185692
|
185693
|
185694
|
185695
|
185696
|
185697
|
185698
|
185699
|
185700
|
185701
|
185702
|
189266
|
189267
|
189268
|
189269
|
189270
|
189271
|
189272
|
189273
|
189274
|
189275
|
189276
|
189277
|
189278
|
189279
|
189280
|
189281
|
189282
|
189283
|
189284
|
189285
|
189286
|
189287
|
189288
|
189289
|
189290
|
189291
|
189292
|
193377
|
193378
|
193379
|
193380
|
193381
|
193382
|
193383
|
193384
|
193385
|
193386
|
193387
|
193388
|
193389
|
193390
|
193391
|
193392
|
193393
|
193394
|
193395
|
193396
|
193397
|
193398
|
193399
|
193400
|
193401
|
193402
|
193403
|
193404
|
193405
|
193406
|
193407
|
193408
|
193409
|
193410
|
193411
|
193412
|
193413
|
193414
|
193415
|
193416
|
193417
|
193418
|
193419
|
193420
|
193421
|
193422
|
193423
|
193424
|
193425
|
193426
|
193427
|
193428
|
193429
|
193430
|
193431
|
193432
|
193433
|
193434
|
193435
|
193436
|
193437
|
193438
|
193439
|
193440
|
193441
|
193442
|
193443
|
193444
|
193445
|
193446
|
193447
|
193448
|
193449
|
193450
|
193451
|
193452
|
193453
|
193454
|
193455
|
193456
|
193457
|
193458
|
193459
|
193460
|
193547
|
193548
|
193549
|
193550
|
193551
|
193552
|
193553
|
193554
|
193555
|
193556
|
193557
|
193558
|
193559
|
193560
|
193561
|
193562
|
193563
|
193564
|
193565
|
193566
|
193567
|
193568
|
193569
|
193570
|
193571
|
193572
|
193573
|
193574
|
193575
|
193576
| 193577