Bugzilla – Attachment 193906 Details for
Bug 41916
SIP2 module cypress tests failing
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41916: Clean-up obsolete code
Bug-41916-Clean-up-obsolete-code.patch (text/plain), 2.17 KB, created by
Paul Derscheid
on 2026-02-25 15:33:49 UTC
(
hide
)
Description:
Bug 41916: Clean-up obsolete code
Filename:
MIME Type:
Creator:
Paul Derscheid
Created:
2026-02-25 15:33:49 UTC
Size:
2.17 KB
patch
obsolete
>From baeadfe7d13ea686515887ebc9d47ab6495404d4 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@openfifth.co.uk> >Date: Tue, 24 Feb 2026 14:37:20 -0100 >Subject: [PATCH] Bug 41916: Clean-up obsolete code > >No longer needed after bug 40191, but because both that and bug 37893 went in close to each other, this remained. >Removing this fixes the toolbar buttons on the SIP2 account form and fixes the console warning that was causing a failure in cypress tests > >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> >--- > .../components/SIP2/SIP2AccountResource.vue | 20 ------------------- > 1 file changed, 20 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/SIP2/SIP2AccountResource.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/SIP2/SIP2AccountResource.vue >index 207b807d5c7..1a8b06b1ecc 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/SIP2/SIP2AccountResource.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/SIP2/SIP2AccountResource.vue >@@ -926,25 +926,6 @@ export default { > }, > ]; > >- const additionalToolbarButtons = (resource, componentData) => { >- const buttons = { >- form: [ >- { >- title: $__("Submit"), >- form: componentData.resourceForm, >- }, >- { >- to: { >- name: "SIP2AccountsList", >- }, >- title: $__("Cancel"), >- cssClass: "btn btn-link", >- }, >- ], >- }; >- return buttons; >- }; >- > const baseResource = useBaseResource({ > resourceName: "account", > nameAttr: "login_id", >@@ -971,7 +952,6 @@ export default { > APIClient.sip2.httpClient._baseURL + "accounts", > options: { embed: "institution" }, > }, >- additionalToolbarButtons, > stickyToolbar: ["Form"], > embedded: props.embedded, > formGroupsDisplayMode: "accordion", >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41916
:
193770
|
193771
|
193772
|
193773
| 193906 |
193907