Bugzilla – Attachment 193907 Details for
Bug 41916
SIP2 module cypress tests failing
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41916: Update Cypress tests
Bug-41916-Update-Cypress-tests.patch (text/plain), 7.68 KB, created by
Paul Derscheid
on 2026-02-25 15:33:51 UTC
(
hide
)
Description:
Bug 41916: Update Cypress tests
Filename:
MIME Type:
Creator:
Paul Derscheid
Created:
2026-02-25 15:33:51 UTC
Size:
7.68 KB
patch
obsolete
>From f4fdb7f05866158194f68f28f72a8c08f70c6768 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@openfifth.co.uk> >Date: Tue, 24 Feb 2026 15:38:09 +0000 >Subject: [PATCH] Bug 41916: Update Cypress tests > >Button is now 'Save' not 'Submit' after bug 40191 > >On ktd: >cypress run --spec t/cypress/integration/SIP2/* > >All tests must pass > >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> >--- > t/cypress/integration/SIP2/Accounts.ts | 12 ++++++------ > t/cypress/integration/SIP2/Institutions.ts | 10 +++++----- > .../integration/SIP2/SystemPreferenceOverrides.ts | 10 +++++----- > 3 files changed, 16 insertions(+), 16 deletions(-) > >diff --git a/t/cypress/integration/SIP2/Accounts.ts b/t/cypress/integration/SIP2/Accounts.ts >index d2a7f9db7a2..e9dae825163 100644 >--- a/t/cypress/integration/SIP2/Accounts.ts >+++ b/t/cypress/integration/SIP2/Accounts.ts >@@ -136,7 +136,7 @@ describe("Accounts", () => { > cy.left_menu_active_item_is("Accounts"); > > // Fill in the form for normal attributes >- cy.get("#accounts_add").contains("Submit").click(); >+ cy.get("#accounts_add").contains("Save").click(); > cy.get("input:invalid,textarea:invalid,select:invalid").should( > "have.length", > 2 >@@ -195,7 +195,7 @@ describe("Accounts", () => { > > // relationshipWidgets > cy.contains("Add new custom patron field").click(); >- cy.get("#accounts_add").contains("Submit").click(); >+ cy.get("#accounts_add").contains("Save").click(); > cy.get("input:invalid,textarea:invalid,select:invalid").should( > "have.length", > 2 >@@ -239,7 +239,7 @@ describe("Accounts", () => { > cy.intercept("POST", "/api/v1/sip2/accounts", { > statusCode: 500, > }); >- cy.get("#accounts_add").contains("Submit").click(); >+ cy.get("#accounts_add").contains("Save").click(); > > cy.get("main div[class='alert alert-warning']").contains( > "Something went wrong: Error: Internal Server Error" >@@ -250,7 +250,7 @@ describe("Accounts", () => { > statusCode: 201, > body: account, > }); >- cy.get("#accounts_add").contains("Submit").click(); >+ cy.get("#accounts_add").contains("Save").click(); > cy.get("main div[class='alert alert-info']").contains( > "Account created" > ); >@@ -310,7 +310,7 @@ describe("Accounts", () => { > delay: 1000, > }); > }).as("edit-account"); >- cy.get("#accounts_add").contains("Submit").click(); >+ cy.get("#accounts_add").contains("Save").click(); > cy.get("main div[class='modal_centered']").contains("Submitting..."); > cy.wait("@edit-account"); > cy.get("main div[class='alert alert-warning']").contains( >@@ -322,7 +322,7 @@ describe("Accounts", () => { > statusCode: 200, > body: account, > }); >- cy.get("#accounts_add").contains("Submit").click(); >+ cy.get("#accounts_add").contains("Save").click(); > cy.get("main div[class='alert alert-info']").contains( > "Account updated" > ); >diff --git a/t/cypress/integration/SIP2/Institutions.ts b/t/cypress/integration/SIP2/Institutions.ts >index a6e13bdf60c..f1c4dd3fdc7 100644 >--- a/t/cypress/integration/SIP2/Institutions.ts >+++ b/t/cypress/integration/SIP2/Institutions.ts >@@ -57,7 +57,7 @@ describe("Institutions", () => { > cy.left_menu_active_item_is("Institutions"); > > // Fill in the form for normal attributes >- cy.get("#institutions_add").contains("Submit").click(); >+ cy.get("#institutions_add").contains("Save").click(); > cy.get("input:invalid,textarea:invalid,select:invalid").should( > "have.length", > 1 >@@ -83,7 +83,7 @@ describe("Institutions", () => { > cy.intercept("POST", "/api/v1/sip2/institutions", { > statusCode: 500, > }); >- cy.get("#institutions_add").contains("Submit").click(); >+ cy.get("#institutions_add").contains("Save").click(); > > cy.get("main div[class='alert alert-warning']").contains( > "Something went wrong: Error: Internal Server Error" >@@ -94,7 +94,7 @@ describe("Institutions", () => { > statusCode: 201, > body: institution, > }); >- cy.get("#institutions_add").contains("Submit").click(); >+ cy.get("#institutions_add").contains("Save").click(); > cy.get("main div[class='alert alert-info']").contains( > "Institution created" > ); >@@ -152,7 +152,7 @@ describe("Institutions", () => { > delay: 1000, > }); > }); >- cy.get("#institutions_add").contains("Submit").click(); >+ cy.get("#institutions_add").contains("Save").click(); > > cy.get("main div[class='modal_centered']").contains("Submitting..."); > cy.wait(1000); >@@ -165,7 +165,7 @@ describe("Institutions", () => { > statusCode: 200, > body: institution, > }); >- cy.get("#institutions_add").contains("Submit").click(); >+ cy.get("#institutions_add").contains("Save").click(); > cy.get("main div[class='alert alert-info']").contains( > "Institution updated" > ); >diff --git a/t/cypress/integration/SIP2/SystemPreferenceOverrides.ts b/t/cypress/integration/SIP2/SystemPreferenceOverrides.ts >index 6955b0faf3b..a71b0a6bea6 100644 >--- a/t/cypress/integration/SIP2/SystemPreferenceOverrides.ts >+++ b/t/cypress/integration/SIP2/SystemPreferenceOverrides.ts >@@ -73,7 +73,7 @@ describe("SystemPreferenceOverrides", () => { > cy.left_menu_active_item_is("System preference overrides"); > > // Fill in the form for normal attributes >- cy.get("#system_preference_overrides_add").contains("Submit").click(); >+ cy.get("#system_preference_overrides_add").contains("Save").click(); > cy.get("input:invalid,textarea:invalid,select:invalid").should( > "have.length", > 2 >@@ -85,7 +85,7 @@ describe("SystemPreferenceOverrides", () => { > cy.intercept("POST", "/api/v1/sip2/system_preference_overrides", { > statusCode: 500, > }); >- cy.get("#system_preference_overrides_add").contains("Submit").click(); >+ cy.get("#system_preference_overrides_add").contains("Save").click(); > > cy.get("main div[class='alert alert-warning']").contains( > "Something went wrong: Error: Internal Server Error" >@@ -96,7 +96,7 @@ describe("SystemPreferenceOverrides", () => { > statusCode: 201, > body: system_preference_override, > }); >- cy.get("#system_preference_overrides_add").contains("Submit").click(); >+ cy.get("#system_preference_overrides_add").contains("Save").click(); > cy.get("main div[class='alert alert-info']").contains( > "System preference override created" > ); >@@ -157,7 +157,7 @@ describe("SystemPreferenceOverrides", () => { > }); > } > ); >- cy.get("#system_preference_overrides_add").contains("Submit").click(); >+ cy.get("#system_preference_overrides_add").contains("Save").click(); > > cy.get("main div[class='modal_centered']").contains("Submitting..."); > cy.wait(1000); >@@ -170,7 +170,7 @@ describe("SystemPreferenceOverrides", () => { > statusCode: 200, > body: system_preference_overrides, > }); >- cy.get("#system_preference_overrides_add").contains("Submit").click(); >+ cy.get("#system_preference_overrides_add").contains("Save").click(); > cy.get("main div[class='alert alert-info']").contains( > "System preference override updated" > ); >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41916
:
193770
|
193771
|
193772
|
193773
|
193906
| 193907