Bugzilla – Attachment 193967 Details for
Bug 38365
Add Content-Security-Policy HTTP header to HTML responses
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38365: (follow-up) Only get the nonce in templates if CSP is enabled, add tests
Bug-38365-follow-up-Only-get-the-nonce-in-template.patch (text/plain), 2.08 KB, created by
David Cook
on 2026-02-26 02:08:15 UTC
(
hide
)
Description:
Bug 38365: (follow-up) Only get the nonce in templates if CSP is enabled, add tests
Filename:
MIME Type:
Creator:
David Cook
Created:
2026-02-26 02:08:15 UTC
Size:
2.08 KB
patch
obsolete
>From 96784f2bfddb9364f71e00a43a4d417a8e25ddd2 Mon Sep 17 00:00:00 2001 >From: Lari Taskula <lari.taskula@hypernova.fi> >Date: Tue, 24 Feb 2026 13:47:15 +0200 >Subject: [PATCH] Bug 38365: (follow-up) Only get the nonce in templates if CSP > is enabled, add tests > >To test: >1. prove t/db_dependent/Koha/Template/Plugin/Koha.t > >Signed-off-by: David Cook <dcook@prosentient.com.au> >--- > t/db_dependent/Koha/Template/Plugin/Koha.t | 23 ++++++++++++++++++---- > 1 file changed, 19 insertions(+), 4 deletions(-) > >diff --git a/t/db_dependent/Koha/Template/Plugin/Koha.t b/t/db_dependent/Koha/Template/Plugin/Koha.t >index 67c0d986dd0..09bebfa6a5e 100755 >--- a/t/db_dependent/Koha/Template/Plugin/Koha.t >+++ b/t/db_dependent/Koha/Template/Plugin/Koha.t >@@ -29,6 +29,8 @@ use Koha::Cache::Memory::Lite; > use Koha::Database; > use Koha::Template::Plugin::Koha; > >+use t::lib::Mocks; >+ > my $schema = Koha::Database->new->schema; > > my $session_id = 42; >@@ -81,7 +83,7 @@ subtest 'GenerateCSRF - New CSRF token generated every time we need one' => sub > }; > > subtest 'CSPNonce' => sub { >- plan tests => 1; >+ plan tests => 3; > > $schema->storage->txn_begin; > >@@ -90,12 +92,25 @@ subtest 'CSPNonce' => sub { > > my $plugin = Koha::Template::Plugin::Koha->new($context); > >- my $csp = Koha::ContentSecurityPolicy->new; >- my $nonce = $csp->get_nonce; >+ C4::Context->interface('opac'); >+ t::lib::Mocks::mock_config( >+ 'content_security_policy', >+ { 'opac' => { csp_mode => 'enabled', csp_header_value => 'test' } } >+ ); > >- my $token = $plugin->CSPNonce; >+ my $csp = Koha::ContentSecurityPolicy->new; >+ $csp->set_nonce(); >+ my $nonce = $csp->get_nonce; > > is( $plugin->CSPNonce, $nonce, 'the correct nonce was provided' ); >+ like( $nonce, qr/^\w{22}$/, 'nonce is a random string of 22 characters' ); >+ >+ t::lib::Mocks::mock_config( >+ 'content_security_policy', >+ { 'opac' => { csp_mode => 'disabled', csp_header_value => 'test' } } >+ ); >+ >+ is( $plugin->CSPNonce, undef, 'no nonce was provided because CSP is dsabled' ); > > $schema->storage->txn_rollback; > >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38365
:
174054
|
188487
|
188488
|
188489
|
188490
|
188491
|
188733
|
188734
|
188735
|
188736
|
188737
|
188881
|
188882
|
189465
|
189466
|
189467
|
189468
|
189469
|
189470
|
189471
|
189472
|
191618
|
191619
|
191620
|
191621
|
191622
|
191623
|
191660
|
191661
|
191662
|
191663
|
191664
|
191665
|
191666
|
191667
|
191668
|
192294
|
192295
|
192296
|
192297
|
192298
|
192299
|
192300
|
192301
|
192302
|
192303
|
192304
|
192305
|
192306
|
192412
|
192413
|
192414
|
192415
|
192416
|
192417
|
192418
|
192419
|
192420
|
192421
|
192422
|
192423
|
192424
|
192425
|
192426
|
192427
|
192428
|
192429
|
192524
|
192535
|
192536
|
192537
|
192553
|
192554
|
192555
|
192556
|
192557
|
192558
|
192559
|
192560
|
192561
|
192562
|
192563
|
192564
|
192565
|
192566
|
192567
|
192568
|
192569
|
192570
|
192571
|
192572
|
192573
|
192574
|
192684
|
192685
|
192686
|
192691
|
192692
|
192693
|
192694
|
192695
|
192696
|
192697
|
192698
|
192699
|
192700
|
192701
|
192702
|
192703
|
192704
|
192705
|
192706
|
192707
|
192708
|
192709
|
192738
|
192843
|
192844
|
192934
|
192935
|
192936
|
192937
|
193288
|
193289
|
193290
|
193291
|
193292
|
193293
|
193294
|
193295
|
193296
|
193297
|
193298
|
193299
|
193300
|
193301
|
193302
|
193303
|
193304
|
193305
|
193306
|
193307
|
193308
|
193309
|
193310
|
193311
|
193312
|
193335
|
193705
|
193706
|
193707
|
193708
|
193709
|
193710
|
193711
|
193712
|
193713
|
193714
|
193941
|
193942
|
193943
|
193944
|
193945
|
193946
|
193947
|
193948
|
193949
|
193950
|
193951
|
193952
|
193953
|
193954
|
193955
|
193956
|
193957
|
193958
|
193959
|
193960
|
193961
|
193962
|
193963
|
193964
|
193965
|
193966
| 193967 |
193968