Bugzilla – Attachment 193982 Details for
Bug 41942
Hiding primary contact method hides lang with PatronSelfModificationBorrowerUnwantedField
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41942: Fix lang hidding in opac patron modification
Bug-41942-Fix-lang-hidding-in-opac-patron-modifica.patch (text/plain), 9.52 KB, created by
Owen Leonard
on 2026-02-26 12:43:14 UTC
(
hide
)
Description:
Bug 41942: Fix lang hidding in opac patron modification
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2026-02-26 12:43:14 UTC
Size:
9.52 KB
patch
obsolete
>From b4e42bf429a9982e42875e01d335e124dd584ab6 Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Thu, 26 Feb 2026 11:03:49 +0100 >Subject: [PATCH] Bug 41942: Fix lang hidding in opac patron modification > >Bug 34438 added lang in opac registration/modification form. >But it is linked to primary contact method hidden or not. > >Looks like this is not on purpose. >This patch removes this link. > >Test plan: >1) Verify system preference > 'PatronSelfModificationBorrowerUnwantedField' is empty >2) Go to OPAC user account > Personal details >3) You see 'Preferred language for notices' >4) In system preference 'PatronSelfModificationBorrowerUnwantedField' > check 'primary_contact_method' >5) Go to OPAC user account > Personal details > => Without patch lang is also hidden > => With patch lang is not hidden > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > .../bootstrap/en/modules/opac-memberentry.tt | 72 +++++++++---------- > 1 file changed, 36 insertions(+), 36 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt >index 8a7563c7756..d8aac16cc2f 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt >@@ -836,43 +836,43 @@ > </select> > [% IF ( mandatory.defined('primary_contact_method') ) %]<span class="required">Required</span>[% END %] > </li> >- [% UNLESS hidden.defined('lang') %] >- <li> >- [% IF ( mandatory.defined('lang') ) %] >- <label for="borrower_lang" class="required">Preferred language for notices: </label> >- [% ELSE %] >- <label for="borrower_lang">Preferred language for notices: </label> >- [% END %] >- <select id="borrower_lang" name="borrower_lang" [% IF ( mandatory.defined('lang') ) %]required[% END %]> >- <option value="default">Default</option> >- [% FOR language IN languages %] >- [% FOR sublanguage IN language.sublanguages_loop %] >- [% IF language.plural %] >- [% IF sublanguage.rfc4646_subtag == borrower.lang %] >- <option value="[% sublanguage.rfc4646_subtag | html %]" selected="selected" >- >[% sublanguage.native_description | html %] [% sublanguage.region_description | html %] ([% sublanguage.rfc4646_subtag | html %])</option >- > >- [% ELSE %] >- <option value="[% sublanguage.rfc4646_subtag | html %]" >- >[% sublanguage.native_description | html %] [% sublanguage.region_description | html %] ([% sublanguage.rfc4646_subtag | html %])</option >- > >- [% END %] >+ [% END %] >+ [% UNLESS hidden.defined('lang') %] >+ <li> >+ [% IF ( mandatory.defined('lang') ) %] >+ <label for="borrower_lang" class="required">Preferred language for notices: </label> >+ [% ELSE %] >+ <label for="borrower_lang">Preferred language for notices: </label> >+ [% END %] >+ <select id="borrower_lang" name="borrower_lang" [% IF ( mandatory.defined('lang') ) %]required[% END %]> >+ <option value="default">Default</option> >+ [% FOR language IN languages %] >+ [% FOR sublanguage IN language.sublanguages_loop %] >+ [% IF language.plural %] >+ [% IF sublanguage.rfc4646_subtag == borrower.lang %] >+ <option value="[% sublanguage.rfc4646_subtag | html %]" selected="selected" >+ >[% sublanguage.native_description | html %] [% sublanguage.region_description | html %] ([% sublanguage.rfc4646_subtag | html %])</option >+ > > [% ELSE %] >- [% IF sublanguage.rfc4646_subtag == borrower.lang %] >- <option value="[% sublanguage.rfc4646_subtag | html %]" selected="selected" >- >[% sublanguage.native_description | html %] ([% sublanguage.rfc4646_subtag | html %])</option >- > >- [% ELSE %] >- <option value="[% sublanguage.rfc4646_subtag | html %]">[% sublanguage.native_description | html %] ([% sublanguage.rfc4646_subtag | html %])</option> >- [% END %] >- [% END # /IF language.plural %] >- [% END # /FOR sublanguage %] >- [% END #/FOR language %] >- </select> >- <!-- /#lang --> >- [% IF ( mandatory.defined('lang') ) %]<div class="required_label required">Required</div>[% END %] >- </li> >- [% END %] >+ <option value="[% sublanguage.rfc4646_subtag | html %]" >+ >[% sublanguage.native_description | html %] [% sublanguage.region_description | html %] ([% sublanguage.rfc4646_subtag | html %])</option >+ > >+ [% END %] >+ [% ELSE %] >+ [% IF sublanguage.rfc4646_subtag == borrower.lang %] >+ <option value="[% sublanguage.rfc4646_subtag | html %]" selected="selected" >+ >[% sublanguage.native_description | html %] ([% sublanguage.rfc4646_subtag | html %])</option >+ > >+ [% ELSE %] >+ <option value="[% sublanguage.rfc4646_subtag | html %]">[% sublanguage.native_description | html %] ([% sublanguage.rfc4646_subtag | html %])</option> >+ [% END %] >+ [% END # /IF language.plural %] >+ [% END # /FOR sublanguage %] >+ [% END #/FOR language %] >+ </select> >+ <!-- /#lang --> >+ [% IF ( mandatory.defined('lang') ) %]<div class="required_label required">Required</div>[% END %] >+ </li> > [% END %] > </ol> > </fieldset> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41942
:
193976
| 193982