Bugzilla – Attachment 194076 Details for
Bug 10190
Overdue notice triggers based on item type
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10190: fix three regressions in overdue_notices.pl
640d8e6.patch (text/plain), 2.89 KB, created by
Martin Renvoize (ashimema)
on 2026-02-27 07:16:08 UTC
(
hide
)
Description:
Bug 10190: fix three regressions in overdue_notices.pl
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2026-02-27 07:16:08 UTC
Size:
2.89 KB
patch
obsolete
>From 640d8e60a30d982b47e19848b290d76e89cf6ced Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@openfifth.co.uk> >Date: Wed, 25 Feb 2026 11:57:53 +0000 >Subject: [PATCH] Bug 10190: fix three regressions in overdue_notices.pl > >- Store patron name/address fields in \$borrower_overdues so > prepare_letter_for_printing has data for printed/CSV/text notices >- Fix email->print fallback: look up items under original MTT key, > not the effective (fallback) key >- Set \$admin_email_address from \$library unconditionally in > _enact_trigger; previously undef in non-patron_homelibrary mode, > stripping the from_address on all queued notices >--- > misc/cronjobs/overdue_notices.pl | 13 +++++++++++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > >diff --git a/misc/cronjobs/overdue_notices.pl b/misc/cronjobs/overdue_notices.pl >index a8205a1273c..28b1fe51ea1 100755 >--- a/misc/cronjobs/overdue_notices.pl >+++ b/misc/cronjobs/overdue_notices.pl >@@ -754,6 +754,14 @@ END_SQL > $borrower_overdues->{'B_email'} = $data->{'B_email'}; > $borrower_overdues->{'smsalertnumber'} = $data->{'smsalertnumber'}; > $borrower_overdues->{'phone'} = $data->{'phone'}; >+ $borrower_overdues->{'firstname'} = $data->{'firstname'}; >+ $borrower_overdues->{'surname'} = $data->{'surname'}; >+ $borrower_overdues->{'address'} = $data->{'address'}; >+ $borrower_overdues->{'address2'} = $data->{'address2'}; >+ $borrower_overdues->{'city'} = $data->{'city'}; >+ $borrower_overdues->{'zipcode'} = $data->{'zipcode'}; >+ $borrower_overdues->{'country'} = $data->{'country'}; >+ $borrower_overdues->{'cardnumber'} = $data->{'cardnumber'}; > } > } > $sth->finish; >@@ -849,7 +857,8 @@ sub _enact_trigger { > my $branchcode = $borrower_overdues->{branchcode}; > my $patron = Koha::Patrons->find($borrowernumber); > my ( $library, $admin_email_address, $branch_email_address ); >- $library = Koha::Libraries->find($branchcode); >+ $library = Koha::Libraries->find($branchcode); >+ $admin_email_address = $library->from_email_address; > > if ($patron_homelibrary) { > $branchcode = $patron->branchcode; >@@ -891,7 +900,7 @@ sub _enact_trigger { > my $itemcount = 0; > my $titles = ""; > my @items = (); >- for my $item_info ( @{ $borrower_overdues->{triggers}->{$trigger}->{$notice}->{$effective_mtt} } ) { >+ for my $item_info ( @{ $borrower_overdues->{triggers}->{$trigger}->{$notice}->{$mtt} } ) { > if ( ( scalar(@emails_to_use) == 0 || $nomail ) > && $PrintNoticesMaxLines > && $j >= $PrintNoticesMaxLines ) >-- >2.53.0 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10190
:
170357
|
170358
|
170359
|
170360
|
170361
|
170362
|
170363
|
170364
|
170365
|
170366
|
170367
|
170368
|
170369
|
170370
|
170371
|
170372
|
170373
|
170374
|
170375
|
170376
|
170380
|
170449
|
171727
|
171728
|
171729
|
171730
|
171731
|
171732
|
171733
|
171734
|
171735
|
171736
|
171737
|
171738
|
171739
|
171740
|
171741
|
171742
|
171743
|
171744
|
171745
|
171746
|
171747
|
171748
|
171749
|
171750
|
171751
|
171752
|
171753
|
171754
|
171755
|
172588
|
172589
|
172590
|
172591
|
172592
|
172593
|
172594
|
172595
|
172596
|
172597
|
172598
|
172599
|
172600
|
172601
|
172602
|
172603
|
172604
|
172605
|
172606
|
172607
|
172608
|
172609
|
172612
|
172614
|
172617
|
172619
|
172621
|
172622
|
172623
|
172624
|
172625
|
172626
|
172630
|
172631
|
172632
|
172633
|
172634
|
172635
|
172636
|
172637
|
172638
|
172639
|
172640
|
172641
|
172642
|
172643
|
172644
|
172645
|
172646
|
172647
|
172648
|
172649
|
172650
|
172651
|
172652
|
172653
|
172654
|
172655
|
172656
|
172657
|
172658
|
172659
|
172660
|
172661
|
172662
|
172663
|
178643
|
178644
|
178645
|
178646
|
178647
|
178648
|
178649
|
178650
|
178651
|
178652
|
178653
|
178654
|
178655
|
178656
|
178657
|
178658
|
178659
|
178660
|
178661
|
178662
|
178663
|
178664
|
178665
|
178666
|
178667
|
178668
|
178669
|
178670
|
178671
|
178672
|
178673
|
178674
|
178675
|
188075
|
188076
|
188077
|
188078
|
188079
|
188080
|
188081
|
188082
|
188083
|
188084
|
188085
|
188086
|
188087
|
188088
|
188476
|
189345
|
189863
|
189864
|
189865
|
189866
|
189867
|
189868
|
191749
|
191750
|
191751
|
191752
|
191753
|
191754
|
191755
|
191756
|
191757
|
191758
|
191759
|
191760
|
191761
|
191762
|
191763
|
191795
|
191796
|
191805
|
191854
|
191873
|
192871
|
192872
|
192873
|
192874
|
192875
|
192876
|
192877
|
192878
|
192879
|
192880
|
192881
|
192882
|
192883
|
192884
|
192885
|
192886
|
192887
|
192888
|
192889
|
192890
|
192891
|
192892
|
192893
|
192894
|
192895
|
192896
|
192897
|
192898
|
192899
|
193864
|
193866
|
193867
|
193868
|
193869
|
193870
|
193871
|
193872
|
193873
|
193874
|
193875
|
193876
|
193877
|
193878
|
193879
|
193880
|
193881
|
193882
|
193883
|
193884
|
193885
|
193886
|
193887
|
193888
|
193889
|
193890
|
193891
|
193892
|
193893
|
193894
|
193895
|
193896
|
193897
|
193898
|
193899
|
193900
|
193901
|
193902
|
193903
|
193904
|
193905
|
193979
|
194045
|
194046
|
194047
|
194048
|
194049
|
194050
|
194051
|
194052
|
194053
|
194054
|
194055
|
194056
|
194057
|
194058
|
194059
|
194060
|
194061
|
194062
|
194063
|
194064
|
194065
|
194066
|
194067
|
194068
|
194069
|
194070
|
194071
|
194072
|
194073
|
194074
|
194075
| 194076 |
194077
|
194078
|
194079
|
194080
|
194081
|
194082
|
194083
|
194084
|
194085
|
194086
|
194087
|
194088
|
194090
|
194094