Bugzilla – Attachment 194092 Details for
Bug 41444
Fetch transfers directly for search results
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41444: (QA follow-up) Rearrange comments
Bug-41444-QA-follow-up-Rearrange-comments.patch (text/plain), 2.25 KB, created by
Marcel de Rooy
on 2026-02-27 08:36:44 UTC
(
hide
)
Description:
Bug 41444: (QA follow-up) Rearrange comments
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2026-02-27 08:36:44 UTC
Size:
2.25 KB
patch
obsolete
>From 4865deb0a6ced239e8435b8dbc833691e6e4bcc8 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 27 Feb 2026 09:32:23 +0100 >Subject: [PATCH] Bug 41444: (QA follow-up) Rearrange comments >Content-Type: text/plain; charset=utf-8 > >It would be at least helpful to add a reference to get_transfer here, >since we are replacing it here. >Used the opportunity to update the older comments > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > C4/Search.pm | 15 +++------------ > 1 file changed, 3 insertions(+), 12 deletions(-) > >diff --git a/C4/Search.pm b/C4/Search.pm >index e43f3497ad..cb906acd3c 100644 >--- a/C4/Search.pm >+++ b/C4/Search.pm >@@ -1957,6 +1957,7 @@ sub searchResults { > # is item a waiting recall? > my $recallstatus = ''; > >+ # Check some statuses before checking transfer info, respect MaxSearchResultsItemsPerRecordStatusCheck > unless ( > $item->{withdrawn} > || $item->{itemlost} >@@ -1967,18 +1968,8 @@ sub searchResults { > ) > { > >- # A couple heuristics to limit how many times >- # we query the database for item transfer information, sacrificing >- # accuracy in some cases for speed; >- # >- # 1. don't query if item has one of the other statuses >- # 2. don't check transit status if the bib has >- # more than 20 items >- # >- # FIXME: to avoid having the query the database like this, and to make >- # the in transit status count as unavailable for search limiting, >- # should map transit status to record indexed in Zebra. >- >+ # NOTE: We are bypassing an expected Koha::Item->get_transfer call here for speed. >+ # TODO: Could we index the transfer status ? > my $transfer = Koha::Item::Transfers->search( > { itemnumber => $item->{itemnumber}, datearrived => undef, datecancelled => undef }, > { order_by => [ { '-desc' => 'datesent' }, { '-asc' => 'daterequested' } ] } >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41444
:
190469
|
190474
|
194091
| 194092