Bugzilla – Attachment 194099 Details for
Bug 41619
Add `Koha::CSV`
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41619: (Follow-up) Fix for t/Koha/CSV.t
eadeab6.patch (text/plain), 1.56 KB, created by
Jake Deery
on 2026-02-27 11:09:15 UTC
(
hide
)
Description:
Bug 41619: (Follow-up) Fix for t/Koha/CSV.t
Filename:
MIME Type:
Creator:
Jake Deery
Created:
2026-02-27 11:09:15 UTC
Size:
1.56 KB
patch
obsolete
>From eadeab6dd2f9083b804593cd8705c847a11aa0e3 Mon Sep 17 00:00:00 2001 >From: Jake Deery <jake.deery@openfifth.co.uk> >Date: Fri, 27 Feb 2026 11:08:32 +0000 >Subject: [PATCH] Bug 41619: (Follow-up) Fix for t/Koha/CSV.t > >This patch fixes an omission that caused t/Koha/CSV.t to fail. To test, prove t/Koha/CSV.t and notice how it now passes. >--- > Koha/CSV.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/Koha/CSV.pm b/Koha/CSV.pm >index e8d9d806849..c9527fbbbc2 100644 >--- a/Koha/CSV.pm >+++ b/Koha/CSV.pm >@@ -91,7 +91,7 @@ sub new { > my $self = $class->SUPER::new( > { > binary => 1, # Always 1 for UTF-8 >- formula => undef, # Hard-coded to empty for security >+ formula => 'empty', # Hard-coded to 'empty' for security > always_quote => $params->{always_quote} // 0, # Overridable > eol => $params->{eol} // "\n", # Overridable > sep_char => $sep_char, # From Koha config or override >@@ -101,7 +101,7 @@ sub new { > $self->{_csv} = Text::CSV_XS->new( > { > binary => $self->binary, >- formula => $self->formula // 'empty', >+ formula => $self->formula // 'empty', # Hard-coded catch-all of 'empty' for security > always_quote => $self->always_quote, > eol => $self->eol, > sep_char => $self->sep_char, >-- >2.50.1 (Apple Git-155) >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41619
:
191466
|
191491
|
191551
|
193461
|
193939
| 194099