Bugzilla – Attachment 194150 Details for
Bug 41938
Argument "" isn't numeric in numeric gt (>) ... warnings in circulation.tt
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41938: Argument "" isn't numeric in numeric gt (>) ... warnings in circulation.tt
51e818a.patch (text/plain), 2.05 KB, created by
David Nind
on 2026-02-27 18:07:16 UTC
(
hide
)
Description:
Bug 41938: Argument "" isn't numeric in numeric gt (>) ... warnings in circulation.tt
Filename:
MIME Type:
Creator:
David Nind
Created:
2026-02-27 18:07:16 UTC
Size:
2.05 KB
patch
obsolete
>From 51e818a8636fdabd2473d2885284c50d7eadd53e Mon Sep 17 00:00:00 2001 >From: Roman Dolny <roman.dolny@jezuici.pl> >Date: Wed, 25 Feb 2026 18:48:26 +0000 >Subject: [PATCH] Bug 41938: Argument "" isn't numeric in numeric gt (>) ... > warnings in circulation.tt > >The warnings: > >[WARN] Argument "" isn't numeric in numeric gt (>) at >/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt > line 1072. >[WARN] Argument "" isn't numeric in numeric gt (>) at >/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt > line 1188. > >appears in the plack-intranet-error.log. > >Test plan: >========== >1. Use a fresh KTD, observe plack-intranet-error.log. >2. Find any patron and go to "Check out" tab. >==> Warnings should appear in plack-intranet-error.log >3. Apply the patch; restart_all. >4. Repeat 2. No warnings in plack-intranet-error.log > >Sponsored-by: Ignatianum University in Cracow >Signed-off-by: David Nind <david@davidnind.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >index 7fe3f813b6..e33287339e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >@@ -1051,7 +1051,7 @@ > </div> > <!-- /#barcodeSubmittedModal --> > >-[% IF waiting_holds.count > 0 %] >+[% IF waiting_holds.count && waiting_holds.count > 0 %] > <div id="circ-warnwaitingholds-modal" class="modal audio-alert-action block"> > <div class="modal-dialog"> > <div class="modal-content"> >@@ -1162,7 +1162,7 @@ > barcodeSubmitInFlight = false; > } > }); >- [% IF waiting_holds.count > 0 %] >+ [% IF waiting_holds.count && waiting_holds.count > 0 %] > $('#circ-warnwaitingholds-modal .btn-primary').on('click',function() { > $('#mainform').submit(); > }); >-- >2.39.5 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41938
:
193938
| 194150