Bugzilla – Attachment 194188 Details for
Bug 41880
Logs for moved holds don't indicate original bib number/item number
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41880: Keep original copy of hold for proper logging
Bug-41880-Keep-original-copy-of-hold-for-proper-lo.patch (text/plain), 1.62 KB, created by
David Nind
on 2026-02-28 03:01:04 UTC
(
hide
)
Description:
Bug 41880: Keep original copy of hold for proper logging
Filename:
MIME Type:
Creator:
David Nind
Created:
2026-02-28 03:01:04 UTC
Size:
1.62 KB
patch
obsolete
>From 0f340f071d3f20dfa57836ff13a1e19a31d767d7 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Thu, 26 Feb 2026 17:36:47 +0000 >Subject: [PATCH] Bug 41880: Keep original copy of hold for proper logging > >To test: >0. APPLY PATCH, restart_all. >1. Make sure HoldsLog is enabled >2. Place a record/bib level hold on bib A. >3. Move the hold to bib B. >4. Look at the diff column in the holds log. You should see the Old (0) biblionumber and the New (N) biblionumber. You should see nothing about itemnumber because this is a record level hold. >5. Ensure that the New and Old biblionumbers are the correct ones. >6. Place an item level hold on item A. >7. Mobe the hold to item B >8. Look at the diff column in the holds log. You should see the Old (0) biblionumber and the New (N) biblionumber. You should also see the New and Old itemnumbers since this is an item level hold. >8. Ensure that the New and Old biblionumbers AND the New and Old itemnumbers are correct. > >Signed-off-by: David Nind <david@davidnind.com> >--- > Koha/Hold.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/Koha/Hold.pm b/Koha/Hold.pm >index d886f7d8b5..f4b1b88cf3 100644 >--- a/Koha/Hold.pm >+++ b/Koha/Hold.pm >@@ -188,10 +188,10 @@ $hold->move_hold(); > sub move_hold { > my ( $self, $args ) = @_; > >- my $original = $self; >+ my $original = $self->unblessed; > my $original_biblionumber = $self->biblionumber; > >- my $found = $original->found // ''; >+ my $found = $self->found // ''; > > if ( $found eq 'W' ) { > return { success => 0, error => 'Cannot move a waiting hold' }; >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41880
:
194039
|
194040
|
194181
|
194182
|
194183
| 194188 |
194189
|
194190