Bugzilla – Attachment 194314 Details for
Bug 14962
Temp Shelving Location / On Display Module
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14962: (QA follow-up) Remove display_type filter parameter with no backing field
131f94c.patch (text/plain), 2.01 KB, created by
Martin Renvoize (ashimema)
on 2026-03-02 10:25:03 UTC
(
hide
)
Description:
Bug 14962: (QA follow-up) Remove display_type filter parameter with no backing field
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2026-03-02 10:25:03 UTC
Size:
2.01 KB
patch
obsolete
>From 131f94c4d36e74d83e5ff4e7561df968b94d7a99 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@openfifth.co.uk> >Date: Tue, 24 Feb 2026 13:02:52 +0000 >Subject: [PATCH] Bug 14962: (QA follow-up) Remove display_type filter > parameter with no backing field > >The display_type query parameter was declared on both GET /displays and >GET /public/displays but there is no display_type column in the displays >table, no such property in the schema definition, and no accessor in the >DBIC schema. Remove the parameter to avoid confusing API consumers. > >Sponsored-by: ByWater Solutions >Signed-of-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> >--- > api/v1/swagger/paths/displays.yaml | 5 ----- > api/v1/swagger/paths/public_displays.yaml | 5 ----- > 2 files changed, 10 deletions(-) > >diff --git a/api/v1/swagger/paths/displays.yaml b/api/v1/swagger/paths/displays.yaml >index 75d7bc5747a..c9d0c3caac8 100644 >--- a/api/v1/swagger/paths/displays.yaml >+++ b/api/v1/swagger/paths/displays.yaml >@@ -29,11 +29,6 @@ > description: Filter by display branch > required: false > type: string >- - name: display_type >- in: query >- description: Filter by display type >- required: false >- type: string > - $ref: "../swagger.yaml#/parameters/match" > - $ref: "../swagger.yaml#/parameters/order_by" > - $ref: "../swagger.yaml#/parameters/page" >diff --git a/api/v1/swagger/paths/public_displays.yaml b/api/v1/swagger/paths/public_displays.yaml >index 35bf8640644..007e7e6fa1f 100644 >--- a/api/v1/swagger/paths/public_displays.yaml >+++ b/api/v1/swagger/paths/public_displays.yaml >@@ -24,11 +24,6 @@ > description: Filter by display branch > required: false > type: string >- - name: display_type >- in: query >- description: Filter by display type >- required: false >- type: string > - $ref: "../swagger.yaml#/parameters/match" > - $ref: "../swagger.yaml#/parameters/order_by" > - $ref: "../swagger.yaml#/parameters/page" >-- >2.53.0 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14962
:
190216
|
190217
|
190218
|
190219
|
190220
|
190221
|
190222
|
190223
|
190224
|
190225
|
190226
|
190227
|
190228
|
190229
|
190230
|
190231
|
190232
|
190571
|
190572
|
193719
|
193720
|
193721
|
193722
|
193723
|
193724
|
193725
|
193726
|
193727
|
193728
|
193729
|
193730
|
193731
|
193732
|
193733
|
193734
|
193735
|
193736
|
193737
|
193738
|
193739
|
193740
|
193741
|
193742
|
193743
|
193744
|
193745
|
193746
|
193747
|
193748
|
193749
|
193750
|
193751
|
193752
|
193753
|
193754
|
193755
|
194285
|
194286
|
194287
|
194288
|
194289
|
194290
|
194291
|
194292
|
194293
|
194294
|
194295
|
194296
|
194297
|
194298
|
194299
|
194300
|
194301
|
194302
|
194303
|
194304
|
194305
|
194306
|
194307
|
194308
|
194309
|
194310
|
194311
|
194312
|
194313
| 194314 |
194315
|
194316
|
194317
|
194318
|
194320
|
194321
|
194322