Bugzilla – Attachment 194319 Details for
Bug 41962
Add comment to SearchAuthorities about unused params, update POD accordingly
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41962: Add comment to SearchAuthorities, change POD
Bug-41962-Add-comment-to-SearchAuthorities-change-.patch (text/plain), 1.82 KB, created by
Marcel de Rooy
on 2026-03-02 10:25:34 UTC
(
hide
)
Description:
Bug 41962: Add comment to SearchAuthorities, change POD
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2026-03-02 10:25:34 UTC
Size:
1.82 KB
patch
obsolete
>From 77f69582cad5f45557ab5710eb4b8907291f1b82 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Mon, 2 Mar 2026 11:00:12 +0100 >Subject: [PATCH] Bug 41962: Add comment to SearchAuthorities, change POD >Content-Type: text/plain; charset=utf-8 > >Test plan: >Read the patch. >Search for both parameters to verify that they are not used. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > C4/AuthoritiesMarc.pm | 17 ++++++++++++----- > 1 file changed, 12 insertions(+), 5 deletions(-) > >diff --git a/C4/AuthoritiesMarc.pm b/C4/AuthoritiesMarc.pm >index c2070f4560..ddb20073e0 100644 >--- a/C4/AuthoritiesMarc.pm >+++ b/C4/AuthoritiesMarc.pm >@@ -107,18 +107,25 @@ sub GetAuthMARCFromKohaField { > > =head2 SearchAuthorities > >- (\@finalresult, $nbresults)= &SearchAuthorities($tags, $and_or, >- $excluding, $operator, $value, $offset,$length,$authtypecode, >- $sortby[, $skipmetadata]) >+ ( \@finalresult, $nbresults ) = SearchAuthorities( >+ $tags, $and_or, >+ $excluding, $operator, $value, $offset, $length, $authtypecode, >+ $sortby, $skipmetadata >+ ); >+ >+Note: The parameters and_or and excluding are not supported currently. >+The subexpressions in $tags are hardcoded with OR unless you pass the >+parameter authtypecode. In the latter case AND is used. > >-returns ref to array result and count of results returned >+Returns a results arrayref and a count of results > > =cut > > sub SearchAuthorities { >+ >+ # NOTE: The parameters $and_or, $excluding below are UNUSED here. > my ( $tags, $and_or, $excluding, $operator, $value, $offset, $length, $authtypecode, $sortby, $skipmetadata ) = @_; > >- # warn Dumper($tags, $and_or, $excluding, $operator, $value, $offset,$length,$authtypecode,$sortby); > my $dbh = C4::Context->dbh; > $sortby = "" unless $sortby; > my $query; >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41962
: 194319