Bugzilla – Attachment 194320 Details for
Bug 14962
Temp Shelving Location / On Display Module
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14962: (QA follow-up) Use dt_from_string instead of DateTime->today in Displays->active
1df0234.patch (text/plain), 1.40 KB, created by
Martin Renvoize (ashimema)
on 2026-03-02 10:25:35 UTC
(
hide
)
Description:
Bug 14962: (QA follow-up) Use dt_from_string instead of DateTime->today in Displays->active
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2026-03-02 10:25:35 UTC
Size:
1.40 KB
patch
obsolete
>From 1df0234ecaebfd07f7fe88eeb4550855e56d8f4a Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@openfifth.co.uk> >Date: Tue, 24 Feb 2026 13:23:16 +0000 >Subject: [PATCH] Bug 14962: (QA follow-up) Use dt_from_string instead of > DateTime->today in Displays->active > >DateTime->today uses the system timezone rather than the Koha-configured >timezone, which can cause incorrect date comparisons for libraries that >configure a timezone different from the server's local time. > >Use Koha::DateUtils::dt_from_string, which is the standard Koha convention >and is consistent with every other date comparison in this feature. > >Sponsored-by: ByWater Solutions >Signed-of-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> >--- > Koha/Displays.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/Koha/Displays.pm b/Koha/Displays.pm >index e91483a55e5..05ce9a061ec 100644 >--- a/Koha/Displays.pm >+++ b/Koha/Displays.pm >@@ -20,9 +20,9 @@ package Koha::Displays; > use Modern::Perl; > > use Carp; >-use DateTime; > > use Koha::Database; >+use Koha::DateUtils qw( dt_from_string ); > use Koha::Display; > > use base qw(Koha::Objects); >@@ -73,7 +73,7 @@ Returns displays that are currently active (enabled and within date range if spe > > sub active { > my ($self) = @_; >- my $today = DateTime->today->ymd; >+ my $today = dt_from_string()->truncate( to => 'day' )->ymd; > > return $self->search( > { >-- >2.53.0 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14962
:
190216
|
190217
|
190218
|
190219
|
190220
|
190221
|
190222
|
190223
|
190224
|
190225
|
190226
|
190227
|
190228
|
190229
|
190230
|
190231
|
190232
|
190571
|
190572
|
193719
|
193720
|
193721
|
193722
|
193723
|
193724
|
193725
|
193726
|
193727
|
193728
|
193729
|
193730
|
193731
|
193732
|
193733
|
193734
|
193735
|
193736
|
193737
|
193738
|
193739
|
193740
|
193741
|
193742
|
193743
|
193744
|
193745
|
193746
|
193747
|
193748
|
193749
|
193750
|
193751
|
193752
|
193753
|
193754
|
193755
|
194285
|
194286
|
194287
|
194288
|
194289
|
194290
|
194291
|
194292
|
194293
|
194294
|
194295
|
194296
|
194297
|
194298
|
194299
|
194300
|
194301
|
194302
|
194303
|
194304
|
194305
|
194306
|
194307
|
194308
|
194309
|
194310
|
194311
|
194312
|
194313
|
194314
|
194315
|
194316
|
194317
|
194318
| 194320 |
194321
|
194322