Attachment 19442 Details for Bug 10548 – Moved $count++ into if statements to fix miscount.

[patch] Moved $count++ into if statements to fix miscount.

0001-bug-10548-koha_perl_deps.pl-miscounts-dependencies-d.patch (text/plain), 1.47 KB, created by Mark Tompsett on 2013-07-06 19:56:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Tompsett

Created: 2013-07-06 19:56:14 UTC

Size: 1.47 KB

patch

obsolete

>From 3911e552e25fa0f57dee6ca3f4b5502645d6cdbe Mon Sep 17 00:00:00 2001
>From: Mark Tompsett <mtompset@hotmail.com>
>Date: Sat, 6 Jul 2013 15:50:54 -0400
>Subject: [PATCH] bug 10548 - koha_perl_deps.pl miscounts dependencies
> displayed
>
>By relocating the $count++ inside the two if statements that
>actually print, the counter is corrected.
>---
> koha_perl_deps.pl |    3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/koha_perl_deps.pl b/koha_perl_deps.pl
>index 123bcd2..54e6de0 100755
>--- a/koha_perl_deps.pl
>+++ b/koha_perl_deps.pl
>@@ -62,7 +62,6 @@ foreach my $type (@pm) {
>             print color 'yellow' if $type eq 'upgrade_pm' && $color;
>             print color 'red' if $type eq 'missing_pm' && $color;
>             print color 'green' if $type eq 'current_pm' && $color;
>-            $count++;
>             my $required = ($_->{$pm}->{'required'}?'Yes':'No');
>             my $current_version = ($color ? $_->{$pm}->{'cur_ver'} :
>                                    $type eq 'missing_pm' || $type eq 'upgrade_pm' ? $_->{$pm}->{'cur_ver'}." *" : $_->{$pm}->{'cur_ver'});
>@@ -73,11 +72,13 @@ format =
> $pm,                                          $current_version, $_->{$pm}->{'min_ver'},  $required
> .
> write;
>+                    $count++;
>                 }
>             }
>             else {
>                 if (($req && $required eq 'Yes') || !$req) {
>                     print "$pm\n";
>+                    $count++;
>                 }
>             }
>         }
>-- 
>1.7.9.5
>

Actions: View | Diff | Splinter Review

Attachments on bug 10548: 19442 | 19524 | 19568