Bugzilla – Attachment 194436 Details for
Bug 41605
Fix incorrect default value keys in Vue
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41605: Fix incorrect default key
Bug-41605-Fix-incorrect-default-key.patch (text/plain), 1.54 KB, created by
Matt Blenkinsop
on 2026-03-04 09:36:30 UTC
(
hide
)
Description:
Bug 41605: Fix incorrect default key
Filename:
MIME Type:
Creator:
Matt Blenkinsop
Created:
2026-03-04 09:36:30 UTC
Size:
1.54 KB
patch
obsolete
>From 5f569f20d468043992116cb9500ea8b96a5c845e Mon Sep 17 00:00:00 2001 >From: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> >Date: Tue, 13 Jan 2026 16:44:00 +0000 >Subject: [PATCH] Bug 41605: Fix incorrect default key > >Test plan: >No behavioural change but it is an inconsistency in the code >1) Look in base-resource.js at the newResource computed method >2) Confirm that the code in the first conditional block is looking for 'hasOwnProperty("defaultValue")' >3) Check the new patch and confirm that the code has been changed from 'value: false' to 'defaultValue: false' to match this > >There is no behaviour change as boolean fields default to false within the framework but we should remove this inconsistency >--- > .../components/Admin/RecordSources/RecordSourcesResource.vue | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Admin/RecordSources/RecordSourcesResource.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Admin/RecordSources/RecordSourcesResource.vue >index c06ed08ab65..54d5286e926 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Admin/RecordSources/RecordSourcesResource.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Admin/RecordSources/RecordSourcesResource.vue >@@ -59,7 +59,7 @@ export default { > name: "can_be_edited", > type: "checkbox", > label: $__("Can be edited"), >- value: false, >+ defaultValue: false, > }, > ], > }); >-- >2.50.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41605
:
191371
|
194436
|
194437