Bugzilla – Attachment 194440 Details for
Bug 38365
Add Content-Security-Policy HTTP header to HTML responses
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38365: Add xt test
4576583.patch (text/plain), 2.41 KB, created by
Jonathan Druart
on 2026-03-04 10:57:51 UTC
(
hide
)
Description:
Bug 38365: Add xt test
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2026-03-04 10:57:51 UTC
Size:
2.41 KB
patch
obsolete
>From 45765836303eab902382b8fa39ddb30bc91684a8 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 4 Mar 2026 11:14:52 +0100 >Subject: [PATCH] Bug 38365: Add xt test > >--- > xt/find-missing-nonce.t | 62 +++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 62 insertions(+) > create mode 100755 xt/find-missing-nonce.t > >diff --git a/xt/find-missing-nonce.t b/xt/find-missing-nonce.t >new file mode 100755 >index 00000000000..10fbba2dc13 >--- /dev/null >+++ b/xt/find-missing-nonce.t >@@ -0,0 +1,62 @@ >+#!/usr/bin/perl >+ >+# Copyright 2026 Koha development team >+# >+# This file is part of Koha. >+# >+# Koha is free software; you can redistribute it and/or modify it >+# under the terms of the GNU General Public License as published by >+# the Free Software Foundation; either version 3 of the License, or >+# (at your option) any later version. >+# >+# Koha is distributed in the hope that it will be useful, but >+# WITHOUT ANY WARRANTY; without even the implied warranty of >+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >+# GNU General Public License for more details. >+# >+# You should have received a copy of the GNU General Public License >+# along with Koha; if not, see <https://www.gnu.org/licenses>. >+ >+use Modern::Perl; >+use Test::More tests => 3; >+use Test::NoWarnings; >+use File::Slurp; >+use Data::Dumper; >+ >+use Koha::Devel::Files; >+ >+my $dev_files = Koha::Devel::Files->new; >+my @files = $dev_files->ls_tt_files; >+ok( @files > 0, 'We should test something' ); >+ >+my @errors; >+for my $file (@files) { >+ my @e = catch_missing_nonce($file); >+ push @errors, sprintf "%s:%s", $file, join( ",", @e ) if @e; >+} >+ >+is( >+ @errors, 0, >+ "Not all <script> or <style> tags in the following files have 'nonce' attribute (see bug 38365)" >+) or diag( Dumper @errors ); >+ >+sub catch_missing_nonce { >+ my ($file) = @_; >+ >+ my @lines = read_file($file); >+ my @errors; >+ return unless grep { $_ =~ m[<(script|style)] } @lines; >+ my $line_number = 0; >+ for my $line (@lines) { >+ $line_number++; >+ if ( $line =~ m{<script} && $line !~ m{<script nonce=} && $line !~ m{src="} ) { >+ next if $line =~ m{Babeltheque_url_js}; # Exception >+ push @errors, "$line_number: $line"; >+ } >+ if ( $line =~ m{<style} && $line !~ m{<style nonce=} ) { >+ push @errors, "$line_number: $line"; >+ } >+ >+ } >+ return @errors; >+} >-- >2.43.0 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38365
:
174054
|
188487
|
188488
|
188489
|
188490
|
188491
|
188733
|
188734
|
188735
|
188736
|
188737
|
188881
|
188882
|
189465
|
189466
|
189467
|
189468
|
189469
|
189470
|
189471
|
189472
|
191618
|
191619
|
191620
|
191621
|
191622
|
191623
|
191660
|
191661
|
191662
|
191663
|
191664
|
191665
|
191666
|
191667
|
191668
|
192294
|
192295
|
192296
|
192297
|
192298
|
192299
|
192300
|
192301
|
192302
|
192303
|
192304
|
192305
|
192306
|
192412
|
192413
|
192414
|
192415
|
192416
|
192417
|
192418
|
192419
|
192420
|
192421
|
192422
|
192423
|
192424
|
192425
|
192426
|
192427
|
192428
|
192429
|
192524
|
192535
|
192536
|
192537
|
192553
|
192554
|
192555
|
192556
|
192557
|
192558
|
192559
|
192560
|
192561
|
192562
|
192563
|
192564
|
192565
|
192566
|
192567
|
192568
|
192569
|
192570
|
192571
|
192572
|
192573
|
192574
|
192684
|
192685
|
192686
|
192691
|
192692
|
192693
|
192694
|
192695
|
192696
|
192697
|
192698
|
192699
|
192700
|
192701
|
192702
|
192703
|
192704
|
192705
|
192706
|
192707
|
192708
|
192709
|
192738
|
192843
|
192844
|
192934
|
192935
|
192936
|
192937
|
193288
|
193289
|
193290
|
193291
|
193292
|
193293
|
193294
|
193295
|
193296
|
193297
|
193298
|
193299
|
193300
|
193301
|
193302
|
193303
|
193304
|
193305
|
193306
|
193307
|
193308
|
193309
|
193310
|
193311
|
193312
|
193335
|
193705
|
193706
|
193707
|
193708
|
193709
|
193710
|
193711
|
193712
|
193713
|
193714
|
193941
|
193942
|
193943
|
193944
|
193945
|
193946
|
193947
|
193948
|
193949
|
193950
|
193951
|
193952
|
193953
|
193954
|
193955
|
193956
|
193957
|
193958
|
193959
|
193960
|
193961
|
193962
|
193963
|
193964
|
193965
|
193966
|
193967
|
193968
|
194374
|
194422
|
194423
|
194424
|
194425
|
194426
|
194427
|
194428
| 194440 |
194441
|
194448
|
194449