Bugzilla – Attachment 194499 Details for
Bug 41997
Default suggester is not passed by the suggestion creation form
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41997: Submit properly default suggester in suggestion.tt
Bug-41997-Submit-properly-default-suggester-in-sug.patch (text/plain), 3.50 KB, created by
Baptiste Wojtkowski (bwoj)
on 2026-03-05 12:29:15 UTC
(
hide
)
Description:
Bug 41997: Submit properly default suggester in suggestion.tt
Filename:
MIME Type:
Creator:
Baptiste Wojtkowski (bwoj)
Created:
2026-03-05 12:29:15 UTC
Size:
3.50 KB
patch
obsolete
>From ab47653b4fee010c83cb34760be25c0ab610b44d Mon Sep 17 00:00:00 2001 >From: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> >Date: Wed, 4 Mar 2026 16:31:17 +0000 >Subject: [PATCH] Bug 41997: Submit properly default suggester in suggestion.tt > >Steps to reproduce, only on main. >1 - Open a form creation suggestion. >2 - With code explorer, notice that there is: <input type="hidden" id="suggestedby" name="suggestedby" value="" /> in the code >3 - Apply patch >4 - With code explorer, notice that there is: <input type="hidden" id="suggestedby" name="suggestedby" value="51" /> in the code >5 - Submit form, notice the suggester is properly written >--- > .../intranet-tmpl/prog/en/modules/suggestion/suggestion.tt | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >index ad235d56fac..8affb43e396 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >@@ -548,17 +548,20 @@ > [% INCLUDE 'date-format.inc' %] > </td> > <td id="tdsuggestedby"> >- <input type="hidden" id="suggestedby" name="suggestedby" value="[% suggestion.suggestedby | html %]" /> > [% IF ( suggestion.suggester.borrowernumber ) %] >+ <input type="hidden" id="suggestedby" name="suggestedby" value="[% suggestion.suggester.borrowernumber | html %]" /> > <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% suggestion.suggester.borrowernumber | uri %]" > >[% suggestion.suggester.surname | html %], [% suggestion.suggester.firstname | html %] ([% suggestion.suggester.cardnumber | html %])</a > > > [% Branches.GetName( suggestion.suggester.branchcode ) | html %] ([% suggestion.suggester.category.description | html %]) > [% ELSIF ( default_suggester ) %] >+ <input type="hidden" id="suggestedby" name="suggestedby" value="[% default_suggester.borrowernumber | html %]" /> > <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% default_suggester.borrowernumber | uri %]" > >[% default_suggester.surname | html %], [% default_suggester.firstname | html %] ([% default_suggester.cardnumber | html %])</a > > > [% Branches.GetName( default_suggester.branchcode ) | html %] ([% default_suggester.category.description | html %]) >+ [% ELSE %] >+ <input type="hidden" id="suggestedby" name="suggestedby" value="" /> > [% END %] > </td> > <td> >-- >2.43.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41997
: 194499