Bugzilla – Attachment 194565 Details for
Bug 41967
cleanup_database.pl ignores integer values for --labels and --cards and defaults to 1 day
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41967: Ensure --cards argument accepts an integer in cleanup_database.pl
Bug-41967-Ensure---cards-argument-accepts-an-integ.patch (text/plain), 3.13 KB, created by
Ayoub Glizi-Vicioso
on 2026-03-05 22:30:19 UTC
(
hide
)
Description:
Bug 41967: Ensure --cards argument accepts an integer in cleanup_database.pl
Filename:
MIME Type:
Creator:
Ayoub Glizi-Vicioso
Created:
2026-03-05 22:30:19 UTC
Size:
3.13 KB
patch
obsolete
>From e70bb235d2f58d5f72ff480dcc6abac3d706afb5 Mon Sep 17 00:00:00 2001 >From: Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> >Date: Thu, 5 Mar 2026 14:22:55 -0500 >Subject: [PATCH] Bug 41967: Ensure --cards argument accepts an integer in > cleanup_database.pl > >Test plan (for --cards arguments) : > >1. Initial Setup: > a) Go to Tools > Patron card creator > New > Card batch > b) Create two different batches (Batch 1 and Batch 2) using the 'Add by borrowernumber(s):' option. > If using **KTD** you can use the following borrowernumbers for both batches: > 15 > 29 > 47 > else you will need to create your own patrons and enter their borrowernumber. > c) In your terminal, set the timestamps manually: > --OPTION A (KTD users): > ktd --shell > koha-mysql kohadev > > --OPTION B: > Access your database > > Then: > UPDATE creator_batches SET timestamp = DATE_SUB(NOW(), INTERVAL 30 DAY) WHERE batch_id = '1'; > UPDATE creator_batches SET timestamp = DATE_SUB(NOW(), INTERVAL 5 DAY) WHERE batch_id = '2'; > > Note: your batch_id may differ. > >2. Before Applying the Patch: > a) Run the following cleanup script: > ./misc/cronjobs/cleanup_database.pl --cards 15 --confirm --verbose > b) Error in console output > c) Nothing is deleted even though one batch was older than 15 days > SELECT * FROM creator_batches; > >3. Apply The Patch > >4. After Applying The Patch: > a) Redo step 1 (Initial Setup). > b) Run again the following cleanup script: > ./misc/cronjobs/cleanup_database.pl --cards 15 --confirm --verbose > c) Check that the console output says: "Purging ... more than 15 days ago" > d) Batch 1 is deleted, but Batch 2 (5 days old) is STILL PRESENT. Success! > SELECT * FROM creator_batches; >--- > misc/cronjobs/cleanup_database.pl | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/misc/cronjobs/cleanup_database.pl b/misc/cronjobs/cleanup_database.pl >index 1ebc47df3d..b8accb9e35 100755 >--- a/misc/cronjobs/cleanup_database.pl >+++ b/misc/cronjobs/cleanup_database.pl >@@ -222,7 +222,7 @@ GetOptions( > 'pseudo-transactions-from:s' => \$pPseudoTransactionsFrom, > 'pseudo-transactions-to:s' => \$pPseudoTransactionsTo, > 'labels:i' => \$labels, >- 'cards' => \$cards, >+ 'cards:i' => \$cards, > 'return-claims' => \$return_claims, > 'jobs-type:s' => \@jobs_types, > 'jobs-days:i' => \$jobs_days, >@@ -771,11 +771,11 @@ if ($labels) { > > if ($cards) { > print "Purging card creator batches last added to more than $cards days ago.\n" if $verbose; >- my $count = PurgeCreatorBatches( $labels, 'patroncards', $confirm ); >+ my $count = PurgeCreatorBatches( $cards, 'patroncards', $confirm ); > if ($verbose) { > say $confirm > ? sprintf "Done with purging %d card creator batches last added to more than %d days ago.\n", $count, >- $labels >+ $cards > : sprintf "%d card creator batches would have been purged.", $count; > } > } >-- >2.53.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41967
:
194415
|
194550
|
194551
|
194564
| 194565