Bugzilla – Attachment 194623 Details for
Bug 41769
", by" in suggestions table in the staff interface is not translated
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41769: Translate "%s, by %s"
6c1c922.patch (text/plain), 2.11 KB, created by
Jonathan Druart
on 2026-03-06 10:12:32 UTC
(
hide
)
Description:
Bug 41769: Translate "%s, by %s"
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2026-03-06 10:12:32 UTC
Size:
2.11 KB
patch
obsolete
>From 6c1c9229d4436d28a2ab47ca56c44f0681f00423 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 6 Mar 2026 11:09:45 +0100 >Subject: [PATCH] Bug 41769: Translate "%s, by %s" > >Instead of translating ", by" we add more flexibility for languages that >need to invert author and title for instance. >--- > .../intranet-tmpl/prog/en/modules/suggestion/suggestion.tt | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >index 47bdf455990..c95514081bc 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >@@ -1369,10 +1369,8 @@ > searchable: true, > orderable: true, > render: function (data, type, row, meta) { >- let node = '<a href="suggestion.pl?suggestionid=%s&op=show" title="%s">%s'.format(row.suggestion_id, _("suggestion"), row.title); >- if(row.author) { >- node += ", %s %s".format(_("by"),row.author.escapeHtml()); >- } >+ let a = '<a href="suggestion.pl?suggestionid=%s&op=show" title="%s">'.format(row.suggestion_id, _("suggestion")); >+ let node = a + ( row.author ? a + _("%s, by %s").format(row.title.escapeHtml(), row.author.escapeHtml()) : row.title.escapeHtml()); > node += '</a><br />'; > if(row.copyright_date) node += ' © <span class="suggestion_copyrightdate">%s</span>'.format(row.copyright_date); > if(row.volume_desc) node += '; <span class="suggestion_volume">%s:<em>%s</em></span>'.format(_("Volume"), row.volume_desc); >-- >2.43.0 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41769
:
192541
|
192545
|
192546
|
192579
|
194366
|
194367
|
194368
|
194562
|
194563
|
194611
| 194623