Bugzilla – Attachment 19467 Details for
Bug 10125
Babeltheque star image must use sprite
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10125 - Babeltheque star image must use sprite
Bug-10125---Babeltheque-star-image-must-use-sprite.patch (text/plain), 3.38 KB, created by
Jonathan Druart
on 2013-07-08 08:26:10 UTC
(
hide
)
Description:
Bug 10125 - Babeltheque star image must use sprite
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2013-07-08 08:26:10 UTC
Size:
3.38 KB
patch
obsolete
>From d7f0b0d1bbc39e451fe87b6f44cfd9fa538e75a3 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Wed, 3 Jul 2013 14:34:31 -0400 >Subject: [PATCH] Bug 10125 - Babeltheque star image must use sprite > >When I removed images from the OPAC in favor of sprites I didn't take >into account the display of star ratings from Babeltheque. This patch >copies the star ratings display from Koha's own ratings display, >though it is not dependent on JavaScript. > >I'm sure testing would be easy for someone with access to the >Babeltheque service, but I do not. I temporarily modified the template >to set some variables for testing purposes: > > [% SET SEARCH_RESULT.score_int = 3 %] > [% SET SEARCH_RESULT.score_avg = 3 % > [% SET SEARCH_RESULT.num_scores = 87 %] > >This enabled the display of the ratings, allowing me to confirm that >stars display correctly. Ratings should work with and without >OpacStarRatings enabled. > >Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> > >I also fudged the template to test, so QA would need to be done with >someone with Babeltheque access > >Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> >--- > koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt | 14 +++++++++++--- > 1 file changed, 11 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt >index 923effa..9150624 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt >+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt >@@ -571,8 +571,16 @@ $(document).ready(function(){ > [% END %] > > [% IF ( SEARCH_RESULT.score_avg ) %] >- <span class="result_summary"> >- <img src="[% themelang %]/../images/Star[% SEARCH_RESULT.score_int %].gif" title="" style="max-height: 15px;"/> <span style="font-size: 85%;">[% SEARCH_RESULT.score_avg %] / 5 (on [% SEARCH_RESULT.num_scores %] rates)</span> >+ <div class="results_summary"> >+ [% FOREACH i IN [ 1 2 3 4 5 ] %] >+ [% IF ( SEARCH_RESULT.score_int >= i ) %] >+ <div class="star-rating rater-[% i %] star star-rating-applied star-rating-readonly star-rating-on"><a title="[% i %]">[% i %]</a></div> >+ [% ELSE %] >+ <div class="star-rating rater-[% i %] star star-rating-applied star-rating-readonly"><a title="[% i %]">[% i %]</a></div> >+ [% END %] >+ [% END %] >+ <span id="babeltheque-rating_total_[% SEARCH_RESULT.biblionumber %]"> [% SEARCH_RESULT.score_avg %] / 5 (on [% SEARCH_RESULT.num_scores %] rates)</span> >+ > [% IF ( SEARCH_RESULT.num_critics ) %] > <span class="social_data">[% SEARCH_RESULT.num_critics %] Internet user critics</span> > [% END %] >@@ -585,7 +593,7 @@ $(document).ready(function(){ > [% IF ( SEARCH_RESULT.num_quotations ) %] > <span class="social_data">[% SEARCH_RESULT.num_quotations %] Quotations</span> > [% END %] >- </span> >+ </div> > [% END %] > > [% IF ( LibraryThingForLibrariesID ) %]<div class="ltfl_reviews"></div>[% END %] >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10125
:
19381
|
19451
| 19467 |
19468