Bugzilla – Attachment 194689 Details for
Bug 42012
e.preventDefault not called in clubs.tt club_hold_search handler
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 42012: Fix missing preventDefault() call in clubs.tt
Bug-42012-Fix-missing-preventDefault-call-in-clubs.patch (text/plain), 1.10 KB, created by
Paul Derscheid
on 2026-03-06 12:04:23 UTC
(
hide
)
Description:
Bug 42012: Fix missing preventDefault() call in clubs.tt
Filename:
MIME Type:
Creator:
Paul Derscheid
Created:
2026-03-06 12:04:23 UTC
Size:
1.10 KB
patch
obsolete
>From 40ebf93632d47a449a39ce1db684621cb1f558b0 Mon Sep 17 00:00:00 2001 >From: Paul Derscheid <paul.derscheid@lmscloud.de> >Date: Fri, 6 Mar 2026 13:03:56 +0100 >Subject: [PATCH] Bug 42012: Fix missing preventDefault() call in clubs.tt > >- e.preventDefault was missing parentheses, so the default > action was never actually prevented >- The element is an <a href="#"> link, so clicking it would > cause the page to scroll to top >--- > koha-tmpl/intranet-tmpl/prog/en/modules/clubs/clubs.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/clubs.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/clubs.tt >index a1c911bc932..d447ea88b0e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/clubs.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/clubs.tt >@@ -173,7 +173,7 @@ > }); > > $("body").on("click", ".club_hold_search", function (e) { >- e.preventDefault; >+ e.preventDefault(); > var club_id = $(this).data("id"); > SearchToHold(club_id); > }); >-- >2.53.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 42012
: 194689