Bugzilla – Attachment 194750 Details for
Bug 41573
Tidy kohaTable block - patron_lists
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41573: (QA follow-up) Fix missing closing backtick in template literal
Bug-41573-QA-follow-up-Fix-missing-closing-backtic.patch (text/plain), 2.74 KB, created by
Paul Derscheid
on 2026-03-06 15:58:01 UTC
(
hide
)
Description:
Bug 41573: (QA follow-up) Fix missing closing backtick in template literal
Filename:
MIME Type:
Creator:
Paul Derscheid
Created:
2026-03-06 15:58:01 UTC
Size:
2.74 KB
patch
obsolete
>From 366a9aa740e087c072064fa0ac2bd22e392b94e6 Mon Sep 17 00:00:00 2001 >From: Paul Derscheid <paul.derscheid@lmscloud.de> >Date: Fri, 6 Mar 2026 14:16:09 +0100 >Subject: [PATCH] Bug 41573: (QA follow-up) Fix missing closing backtick in > template literal > >- The conversion from string concatenation to a template literal > in addToList() missed the closing backtick >- This causes a syntax error breaking the add-to-list functionality > on the patron lists tab > >Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> >--- > .../prog/en/modules/patron_lists/patron-lists-tab.tt | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/patron-lists-tab.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/patron-lists-tab.tt >index 1f0ce7c3a18..fa9e868c9c5 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/patron-lists-tab.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/patron-lists-tab.tt >@@ -134,22 +134,22 @@ > $("#table_listnopatron").kohaTable(patron_lists_dt_params); > $("#table_inlists").kohaTable(patron_lists_dt_params); > >- if (permissions.CAN_user_tools_manage_patron_lists){ >+ if (permissions.CAN_user_tools_manage_patron_lists) { > function addToList() { > var list_id = $("#add_to_patron_list_id_select").val(); >- $('#pat_lists_panel').text(_("Loading...")); >+ $("#pat_lists_panel").text(_("Loading...")); > $("body").css("cursor", "progress"); >- $('#pat_lists_panel').load(`/cgi-bin/koha/patron_lists/patron-lists-tab.pl?borrowernumber=${patron_id}&patron_list_id=${list_id}&patrons_to_add=${cardnumber}, function() { >+ $("#pat_lists_panel").load(`/cgi-bin/koha/patron_lists/patron-lists-tab.pl?borrowernumber=${patron_id}&patron_list_id=${list_id}&patrons_to_add=${cardnumber}`, function () { > $("body").css("cursor", "default"); > }); > > return false; > } > >- function removeFromList( list_id, patron_list_patron_id ) { >- $('#pat_lists_panel').text(_("Loading...")); >+ function removeFromList(list_id, patron_list_patron_id) { >+ $("#pat_lists_panel").text(_("Loading...")); > $("body").css("cursor", "progress"); >- $('#pat_lists_panel').load(`/cgi-bin/koha/patron_lists/patron-lists-tab.pl?borrowernumber=${patron_id}&patron_list_id=${list_id}&patrons_to_remove=${patron_list_patron_id}`, function() { >+ $("#pat_lists_panel").load(`/cgi-bin/koha/patron_lists/patron-lists-tab.pl?borrowernumber=${patron_id}&patron_list_id=${list_id}&patrons_to_remove=${patron_list_patron_id}`, function () { > $("body").css("cursor", "default"); > }); > >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41573
:
191139
|
191140
|
191141
|
191142
|
194733
|
194734
|
194735
|
194736
|
194737
|
194738
|
194746
|
194747
|
194748
|
194749
| 194750 |
194751