Bugzilla – Attachment 194770 Details for
Bug 41575
Tidy kohaTable block - pos
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41575: (QA follow-up) Fix register description interpolation in cashup modal
Bug-41575-QA-follow-up-Fix-register-description-in.patch (text/plain), 3.39 KB, created by
Paul Derscheid
on 2026-03-06 16:18:27 UTC
(
hide
)
Description:
Bug 41575: (QA follow-up) Fix register description interpolation in cashup modal
Filename:
MIME Type:
Creator:
Paul Derscheid
Created:
2026-03-06 16:18:27 UTC
Size:
3.39 KB
patch
obsolete
>From 68a97c5527b38ad5d7197439e5d7d5f58177ec5f Mon Sep 17 00:00:00 2001 >From: Paul Derscheid <paul.derscheid@lmscloud.de> >Date: Fri, 6 Mar 2026 17:17:35 +0100 >Subject: [PATCH] Bug 41575: (QA follow-up) Fix register description > interpolation in cashup modal > >- The tidy replaced TT interpolation with a JS template literal > expression but left it inside single quotes instead of using > backticks or string concatenation >- This caused the cashup confirmation dialog to show "Confirm cashup > of" with no register name >- The incorrect syntax also silently swallowed quote formatting that > the auto tidy would normally have applied >- Use string concatenation to match the surrounding code style > >Test plan: >- Go to Point of sale, make a sale >- Navigate to Cash summary >- Click "Record cashup" on a register row >- Verify the dialog says "Confirm cashup of <register name>" > instead of "Confirm cashup of" > >Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt | 8 +++++--- > koha-tmpl/intranet-tmpl/prog/en/modules/pos/registers.tt | 2 +- > 2 files changed, 6 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt >index 63eba53943a..c71c2b6f3f9 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt >@@ -576,7 +576,9 @@ > var result = > '<a class="btn btn-default btn-xs" role="button" data-bs-toggle="modal" data-cashup="' + > encodeURIComponent(row.cashup_id) + >- '" data-register="${register.description}" href="#cashupSummaryModal"><i class="fa-solid fa-pencil" aria-hidden="true"></i> ' + >+ '" data-register="' + >+ register.description + >+ '" href="#cashupSummaryModal"><i class="fa-solid fa-pencil" aria-hidden="true"></i> ' + > _("Summary") + > "</a>\n"; > return result; >@@ -590,10 +592,10 @@ > 1 > ); > >- $(document).ready(function() { >+ $(document).ready(function () { > // Check for cashup hash in URL > let hash = window.location.hash; >- if (hash && hash.startsWith('#cashup-')) { >+ if (hash && hash.startsWith("#cashup-")) { > let cashup_id = hash.substring(8); // Remove '#cashup-' prefix > let $button = $('[data-cashup="' + cashup_id + '"]'); > if ($button.length) { >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/pos/registers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/pos/registers.tt >index 3c95f06113b..4c774401895 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/pos/registers.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/pos/registers.tt >@@ -245,7 +245,7 @@ > > // Check for cashup hash in URL > let hash = window.location.hash; >- if (hash && hash.startsWith('#cashup-')) { >+ if (hash && hash.startsWith("#cashup-")) { > let cashup_id = hash.substring(8); // Remove '#cashup-' prefix > let $button = $('[data-cashup="' + cashup_id + '"]'); > if ($button.length) { >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41575
:
191145
|
191146
|
191147
|
191148
|
191410
|
191411
|
191412
|
191413
|
192371
|
192372
|
192373
|
192374
|
194766
|
194767
|
194768
|
194769
| 194770