Bugzilla – Attachment 194802 Details for
Bug 14962
Temp Shelving Location / On Display Module
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14962: (QA follow-up) List all blocked items in one alert
a9ba0ce.patch (text/plain), 3.42 KB, created by
Jake Deery
on 2026-03-06 16:46:15 UTC
(
hide
)
Description:
Bug 14962: (QA follow-up) List all blocked items in one alert
Filename:
MIME Type:
Creator:
Jake Deery
Created:
2026-03-06 16:46:15 UTC
Size:
3.42 KB
patch
obsolete
>From a9ba0ce5831aea486e77a9bf23a8fd5b8883105f Mon Sep 17 00:00:00 2001 >From: Jake Deery <jake.deery@openfifth.co.uk> >Date: Tue, 3 Mar 2026 16:14:01 +0000 >Subject: [PATCH] Bug 14962: (QA follow-up) List all blocked items in one alert > >This patch stops duplication of the alert displayed when an item is not modifiable, and instead shows all the items listed under one single alert > >Sponsored-by: ByWater Solutions >--- > cataloguing/additem.pl | 15 ++++++++++++++- > .../prog/en/modules/cataloguing/additem.tt | 10 +++++++--- > 2 files changed, 21 insertions(+), 4 deletions(-) > >diff --git a/cataloguing/additem.pl b/cataloguing/additem.pl >index 784be908f7b..2e605342c89 100755 >--- a/cataloguing/additem.pl >+++ b/cataloguing/additem.pl >@@ -169,7 +169,10 @@ if ( $op eq 'edititem' || $op eq 'dupeitem' ) { > my $ondisplay = $item->active_display ? 1 : undef; > my $nomod = $ondisplay; > >- $template->param( ondisplay => $ondisplay, nomod => $nomod ); >+ $template->param( >+ ondisplay => $ondisplay, >+ nomod => $nomod >+ ); > } > } > >@@ -699,6 +702,9 @@ if ($op) { > > # now, build existiing item list > >+my $bib_has_nomod; >+my $bib_has_ondisplay; >+ > my @items; > for my $item ( $biblio->items->as_list, $biblio->host_items->as_list ) { > my $i = $item->columns_to_str; >@@ -713,6 +719,9 @@ for my $item ( $biblio->items->as_list, $biblio->host_items->as_list ) { > } > } > >+ $bib_has_nomod = 1 if $i->{nomod}; >+ $bib_has_ondisplay = 1 if $i->{ondisplay}; >+ > push @items, $i; > } > >@@ -837,6 +846,10 @@ $template->param( > barcode => $current_item->{barcode}, > op => $nextop, > popup => scalar $input->param('popup') ? 1 : 0, >+ can_mod => { >+ nomod => scalar $bib_has_nomod ? 1 : 0, >+ ondisplay => scalar $bib_has_ondisplay ? 1 : 0, >+ }, > C4::Search::enabled_staff_search_views, > ); > $template->{'VARS'}->{'searchid'} = $searchid; >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt >index 266f7e52577..e97fb816862 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt >@@ -88,12 +88,16 @@ > </div> > [% END %] > [% IF ( items ) %] >- [% FOREACH item IN items %] >- [% IF item.ondisplay %] >+ [% IF ( can_mod.nomod ) %] >+ [% IF ( can_mod.ondisplay ) %] > <div class="alert alert-warning"> > <p> <strong>Item(s) on display:</strong> The following item is currently on display, and cannot be modified: </p> > <ul> >- <li><a href="/cgi-bin/koha/display/displays/[% item.active_display_id | url %]">[% item.barcode | html %]</a></li> >+ [% FOREACH item IN items %] >+ [% IF item.ondisplay %] >+ <li><a href="/cgi-bin/koha/display/displays/[% item.active_display_id | url %]">[% item.barcode | html %]</a></li> >+ [% END %] >+ [% END %] > </ul> > <p> The permanent location for these item(s) is found below. To modify these details, edit the display, or remove the item from the display. </p> > </div> >-- >2.50.1 (Apple Git-155) >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14962
:
190216
|
190217
|
190218
|
190219
|
190220
|
190221
|
190222
|
190223
|
190224
|
190225
|
190226
|
190227
|
190228
|
190229
|
190230
|
190231
|
190232
|
190571
|
190572
|
193719
|
193720
|
193721
|
193722
|
193723
|
193724
|
193725
|
193726
|
193727
|
193728
|
193729
|
193730
|
193731
|
193732
|
193733
|
193734
|
193735
|
193736
|
193737
|
193738
|
193739
|
193740
|
193741
|
193742
|
193743
|
193744
|
193745
|
193746
|
193747
|
193748
|
193749
|
193750
|
193751
|
193752
|
193753
|
193754
|
193755
|
194285
|
194286
|
194287
|
194288
|
194289
|
194290
|
194291
|
194292
|
194293
|
194294
|
194295
|
194296
|
194297
|
194298
|
194299
|
194300
|
194301
|
194302
|
194303
|
194304
|
194305
|
194306
|
194307
|
194308
|
194309
|
194310
|
194311
|
194312
|
194313
|
194314
|
194315
|
194316
|
194317
|
194318
|
194320
|
194321
|
194322
|
194786
|
194795
|
194796
|
194797
|
194798
|
194799
|
194800
|
194801
|
194802
|
194803
|
194804
|
194805
|
194806
|
194807
|
194808
|
194809
|
194813
|
194814
|
194815
|
194816
|
194817
|
194818
|
194819
|
194820
|
194821
|
194822
|
194823
|
194824
|
194825
|
194826
|
194827
|
194828
|
194829
|
194830
|
194831
|
194832
|
194833
|
194834
|
194835
|
194836
|
194837
|
194838
|
194839
|
194840
|
194841
|
194842
|
194843
|
194844
|
194845
|
194846
|
194847
|
194848
|
194849
|
194850
|
194851
|
194852
|
194853
|
194854
|
194855
|
194856
|
194857
|
194858
|
194859
|
194860
|
194861
|
194862
|
194863
|
194864