Bugzilla – Attachment 194804 Details for
Bug 14962
Temp Shelving Location / On Display Module
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14962: (QA follow-up) Fix edit display hanging when barcode has multiple matches
813e82e.patch (text/plain), 3.21 KB, created by
Jake Deery
on 2026-03-06 16:46:23 UTC
(
hide
)
Description:
Bug 14962: (QA follow-up) Fix edit display hanging when barcode has multiple matches
Filename:
MIME Type:
Creator:
Jake Deery
Created:
2026-03-06 16:46:23 UTC
Size:
3.21 KB
patch
obsolete
>From 813e82ec50aa236b766c1a9ca434f145059c2dd6 Mon Sep 17 00:00:00 2001 >From: Jake Deery <jake.deery@openfifth.co.uk> >Date: Thu, 5 Mar 2026 16:29:18 +0000 >Subject: [PATCH] Bug 14962: (QA follow-up) Fix edit display hanging when > barcode has multiple matches > >This patch fixes a bug where lower-order barcodes could not be added if there were multiple starts_with matches. This will mean librarians can add e.g. an item barcode of 3, when there is an item with barcode of 33 as well. This patch also reduces the number of API calls when a display is viewed, by using the embeded biblio, rather than a separate call. > >Sponsored-by: ByWater Solutions >--- > .../prog/js/fetch/item-api-client.js | 1 + > .../vue/components/Display/DisplaysResource.vue | 15 ++++----------- > 2 files changed, 5 insertions(+), 11 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/fetch/item-api-client.js b/koha-tmpl/intranet-tmpl/prog/js/fetch/item-api-client.js >index 12f6f757ac1..fe5ef6e4cd7 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/fetch/item-api-client.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/fetch/item-api-client.js >@@ -28,6 +28,7 @@ export class ItemAPIClient { > "items?" + > new URLSearchParams({ > _match: "starts_with", >+ _order_by: "me.barcode", > external_id: external_id, > }), > headers: { >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Display/DisplaysResource.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Display/DisplaysResource.vue >index a8025ee6cfe..2e5b35c24d0 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Display/DisplaysResource.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Display/DisplaysResource.vue >@@ -389,7 +389,7 @@ export default { > await itemsApiClient > .getByExternalId(external_id) > .then(data => { >- if (data.length == 1) item = data[0]; >+ if (data.length > 0) item = data[0]; > }) > .catch(error => { > console.error(error); >@@ -519,18 +519,11 @@ export default { > componentData.resource.value.display_items[idx].barcode = > _("Loading"); > >- getBiblioFromId(display_item.biblionumber) >- .then(biblio => { >- componentData.resource.value.display_items[ >- idx >- ].title = biblio.title; >- }) >- .catch(error => { >- console.error(error); >- }); >- > getItemFromId(display_item.itemnumber) > .then(item => { >+ componentData.resource.value.display_items[ >+ idx >+ ].title = item.biblio?.title || _("Unknown biblio"); > componentData.resource.value.display_items[ > idx > ].barcode = item.external_id; >-- >2.50.1 (Apple Git-155) >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14962
:
190216
|
190217
|
190218
|
190219
|
190220
|
190221
|
190222
|
190223
|
190224
|
190225
|
190226
|
190227
|
190228
|
190229
|
190230
|
190231
|
190232
|
190571
|
190572
|
193719
|
193720
|
193721
|
193722
|
193723
|
193724
|
193725
|
193726
|
193727
|
193728
|
193729
|
193730
|
193731
|
193732
|
193733
|
193734
|
193735
|
193736
|
193737
|
193738
|
193739
|
193740
|
193741
|
193742
|
193743
|
193744
|
193745
|
193746
|
193747
|
193748
|
193749
|
193750
|
193751
|
193752
|
193753
|
193754
|
193755
|
194285
|
194286
|
194287
|
194288
|
194289
|
194290
|
194291
|
194292
|
194293
|
194294
|
194295
|
194296
|
194297
|
194298
|
194299
|
194300
|
194301
|
194302
|
194303
|
194304
|
194305
|
194306
|
194307
|
194308
|
194309
|
194310
|
194311
|
194312
|
194313
|
194314
|
194315
|
194316
|
194317
|
194318
|
194320
|
194321
|
194322
|
194786
|
194795
|
194796
|
194797
|
194798
|
194799
|
194800
|
194801
|
194802
|
194803
|
194804
|
194805
|
194806
|
194807
|
194808
|
194809
|
194813
|
194814
|
194815
|
194816
|
194817
|
194818
|
194819
|
194820
|
194821
|
194822
|
194823
|
194824
|
194825
|
194826
|
194827
|
194828
|
194829
|
194830
|
194831
|
194832
|
194833
|
194834
|
194835
|
194836
|
194837
|
194838
|
194839
|
194840
|
194841
|
194842
|
194843
|
194844
|
194845
|
194846
|
194847
|
194848
|
194849
|
194850
|
194851
|
194852
|
194853
|
194854
|
194855
|
194856
|
194857
|
194858
|
194859
|
194860
|
194861
|
194862
|
194863
|
194864