Bugzilla – Attachment 194840 Details for
Bug 14962
Temp Shelving Location / On Display Module
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14962: (QA follow-up) Add date_remove filter to active_display_item
0fd1f4c.patch (text/plain), 1.44 KB, created by
Jake Deery
on 2026-03-06 17:00:03 UTC
(
hide
)
Description:
Bug 14962: (QA follow-up) Add date_remove filter to active_display_item
Filename:
MIME Type:
Creator:
Jake Deery
Created:
2026-03-06 17:00:03 UTC
Size:
1.44 KB
patch
obsolete
>From 0fd1f4ca7986746f78f2cd73c934c39b47097493 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@openfifth.co.uk> >Date: Tue, 24 Feb 2026 13:01:50 +0000 >Subject: [PATCH] Bug 14962: (QA follow-up) Add date_remove filter to > active_display_item > >active_display_item() was missing a date_remove check, unlike >active_display() which correctly excludes expired display items. > >This method is called from C4::Circulation::AddReturn to decide whether >to apply display_return_over logic. Without the filter, items past their >date_remove date would still trigger removal logic even though every >other part of the system treats them as no longer on display. > >Sponsored-by: ByWater Solutions >Signed-of-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> >--- > Koha/Item.pm | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > >diff --git a/Koha/Item.pm b/Koha/Item.pm >index a5620dc2971..37f00a8950d 100644 >--- a/Koha/Item.pm >+++ b/Koha/Item.pm >@@ -818,7 +818,11 @@ sub active_display_item { > -or => [ > { 'display.end_date' => undef }, > { 'display.end_date' => { '>=' => $dtf->format_date($today) } } >- ] >+ ], >+ -or => [ >+ { 'me.date_remove' => undef }, >+ { 'me.date_remove' => { '>=' => $dtf->format_date($today) } } >+ ], > ] > }, > { join => 'display' } >-- >2.50.1 (Apple Git-155) >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14962
:
190216
|
190217
|
190218
|
190219
|
190220
|
190221
|
190222
|
190223
|
190224
|
190225
|
190226
|
190227
|
190228
|
190229
|
190230
|
190231
|
190232
|
190571
|
190572
|
193719
|
193720
|
193721
|
193722
|
193723
|
193724
|
193725
|
193726
|
193727
|
193728
|
193729
|
193730
|
193731
|
193732
|
193733
|
193734
|
193735
|
193736
|
193737
|
193738
|
193739
|
193740
|
193741
|
193742
|
193743
|
193744
|
193745
|
193746
|
193747
|
193748
|
193749
|
193750
|
193751
|
193752
|
193753
|
193754
|
193755
|
194285
|
194286
|
194287
|
194288
|
194289
|
194290
|
194291
|
194292
|
194293
|
194294
|
194295
|
194296
|
194297
|
194298
|
194299
|
194300
|
194301
|
194302
|
194303
|
194304
|
194305
|
194306
|
194307
|
194308
|
194309
|
194310
|
194311
|
194312
|
194313
|
194314
|
194315
|
194316
|
194317
|
194318
|
194320
|
194321
|
194322
|
194786
|
194795
|
194796
|
194797
|
194798
|
194799
|
194800
|
194801
|
194802
|
194803
|
194804
|
194805
|
194806
|
194807
|
194808
|
194809
|
194813
|
194814
|
194815
|
194816
|
194817
|
194818
|
194819
|
194820
|
194821
|
194822
|
194823
|
194824
|
194825
|
194826
|
194827
|
194828
|
194829
|
194830
|
194831
|
194832
|
194833
|
194834
|
194835
|
194836
|
194837
|
194838
|
194839
| 194840 |
194841
|
194842
|
194843
|
194844
|
194845
|
194846
|
194847
|
194848
|
194849
|
194850
|
194851
|
194852
|
194853
|
194854
|
194855
|
194856
|
194857
|
194858
|
194859
|
194860
|
194861
|
194862
|
194863
|
194864