Bugzilla – Attachment 194856 Details for
Bug 14962
Temp Shelving Location / On Display Module
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14962: (QA follow-up) Show Display now shows record title
85dc6be.patch (text/plain), 5.35 KB, created by
Jake Deery
on 2026-03-06 17:00:46 UTC
(
hide
)
Description:
Bug 14962: (QA follow-up) Show Display now shows record title
Filename:
MIME Type:
Creator:
Jake Deery
Created:
2026-03-06 17:00:46 UTC
Size:
5.35 KB
patch
obsolete
>From 85dc6be8ad9d3f7f25e6e5b7aec57b99f3e1e879 Mon Sep 17 00:00:00 2001 >From: Jake Deery <jake.deery@openfifth.co.uk> >Date: Tue, 3 Mar 2026 14:56:01 +0000 >Subject: [PATCH] Bug 14962: (QA follow-up) Show Display now shows record title > >This patch removes the biblionumber from the show display page, and instead shows the record title - still with a hyperlink to the biblio details page. > >Sponsored-by: ByWater Solutions >--- > .../prog/js/fetch/biblio-api-client.js | 10 +++- > .../components/Display/DisplaysResource.vue | 52 +++++++++++++------ > 2 files changed, 44 insertions(+), 18 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/fetch/biblio-api-client.js b/koha-tmpl/intranet-tmpl/prog/js/fetch/biblio-api-client.js >index 6a0ba72553d..ce84e588b79 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/fetch/biblio-api-client.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/fetch/biblio-api-client.js >@@ -12,11 +12,17 @@ export class BiblioAPIClient { > endpoint: "biblios", > query, > params, >- headers, >+ headers: { >+ Accept: "application/json", >+ ...headers, >+ }, > }), > get: id => > this.httpClient.get({ >- endpoint: "items/" + id, >+ endpoint: "biblios/" + id, >+ headers: { >+ Accept: "application/json", >+ }, > }), > }; > } >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Display/DisplaysResource.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Display/DisplaysResource.vue >index 03d984d2d32..b40183d8b56 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Display/DisplaysResource.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Display/DisplaysResource.vue >@@ -251,8 +251,8 @@ export default { > hidden: display => !!display.display_items?.length, > columns: [ > { >- name: $__("Record number"), >- value: "biblionumber", >+ name: $__("Record title"), >+ value: "title", > link: { > href: "/cgi-bin/koha/catalogue/detail.pl", > params: { >@@ -260,16 +260,6 @@ export default { > }, > }, > }, >- { >- name: $__("Internal item number"), >- value: "itemnumber", >- link: { >- href: "/cgi-bin/koha/catalogue/moredetail.pl", >- params: { >- itemnumber: "itemnumber", >- }, >- }, >- }, > { > name: $__("Item barcode"), > value: "barcode", >@@ -360,6 +350,22 @@ export default { > }, > }; > >+ const getBiblioFromId = async id => { >+ const bibliosApiClient = APIClient.biblio.biblios; >+ let item = undefined; >+ >+ await bibliosApiClient >+ .get(id) >+ .then(data => { >+ item = data; >+ }) >+ .catch(error => { >+ console.error(error); >+ }); >+ >+ return item; >+ }; >+ > const getItemFromId = async id => { > const itemsApiClient = APIClient.item.items; > let item = undefined; >@@ -506,12 +512,26 @@ export default { > const afterResourceFetch = (componentData, resource, caller) => { > if (caller === "show" || caller === "form") { > resource.display_items.forEach((display_item, idx) => { >+ componentData.resource.value.display_items[idx].title = >+ _("Loading"); >+ componentData.resource.value.display_items[idx].barcode = >+ _("Loading"); >+ >+ getBiblioFromId(display_item.biblionumber) >+ .then(biblio => { >+ componentData.resource.value.display_items[ >+ idx >+ ].title = biblio.title; >+ }) >+ .catch(error => { >+ console.error(error); >+ }); >+ > getItemFromId(display_item.itemnumber) > .then(item => { >- componentData.resource.value.display_items[idx] = { >- barcode: item.external_id, >- ...display_item, >- }; >+ componentData.resource.value.display_items[ >+ idx >+ ].barcode = item.external_id; > }) > .catch(error => { > console.error(error); >-- >2.50.1 (Apple Git-155) >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14962
:
190216
|
190217
|
190218
|
190219
|
190220
|
190221
|
190222
|
190223
|
190224
|
190225
|
190226
|
190227
|
190228
|
190229
|
190230
|
190231
|
190232
|
190571
|
190572
|
193719
|
193720
|
193721
|
193722
|
193723
|
193724
|
193725
|
193726
|
193727
|
193728
|
193729
|
193730
|
193731
|
193732
|
193733
|
193734
|
193735
|
193736
|
193737
|
193738
|
193739
|
193740
|
193741
|
193742
|
193743
|
193744
|
193745
|
193746
|
193747
|
193748
|
193749
|
193750
|
193751
|
193752
|
193753
|
193754
|
193755
|
194285
|
194286
|
194287
|
194288
|
194289
|
194290
|
194291
|
194292
|
194293
|
194294
|
194295
|
194296
|
194297
|
194298
|
194299
|
194300
|
194301
|
194302
|
194303
|
194304
|
194305
|
194306
|
194307
|
194308
|
194309
|
194310
|
194311
|
194312
|
194313
|
194314
|
194315
|
194316
|
194317
|
194318
|
194320
|
194321
|
194322
|
194786
|
194795
|
194796
|
194797
|
194798
|
194799
|
194800
|
194801
|
194802
|
194803
|
194804
|
194805
|
194806
|
194807
|
194808
|
194809
|
194813
|
194814
|
194815
|
194816
|
194817
|
194818
|
194819
|
194820
|
194821
|
194822
|
194823
|
194824
|
194825
|
194826
|
194827
|
194828
|
194829
|
194830
|
194831
|
194832
|
194833
|
194834
|
194835
|
194836
|
194837
|
194838
|
194839
|
194840
|
194841
|
194842
|
194843
|
194844
|
194845
|
194846
|
194847
|
194848
|
194849
|
194850
|
194851
|
194852
|
194853
|
194854
|
194855
| 194856 |
194857
|
194858
|
194859
|
194860
|
194861
|
194862
|
194863
|
194864