Bugzilla – Attachment 194862 Details for
Bug 14962
Temp Shelving Location / On Display Module
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14962: (QA follow-up) Remove unneccessary condition in moredetail
46089d6.patch (text/plain), 2.39 KB, created by
Jake Deery
on 2026-03-06 17:01:04 UTC
(
hide
)
Description:
Bug 14962: (QA follow-up) Remove unneccessary condition in moredetail
Filename:
MIME Type:
Creator:
Jake Deery
Created:
2026-03-06 17:01:04 UTC
Size:
2.39 KB
patch
obsolete
>From 46089d67053fff581106be82d58774d4e5cbfab3 Mon Sep 17 00:00:00 2001 >From: Jake Deery <jake.deery@openfifth.co.uk> >Date: Fri, 6 Mar 2026 14:40:16 +0000 >Subject: [PATCH] Bug 14962: (QA follow-up) Remove unneccessary condition in > moredetail > >This patch simplifies some of the code in moredetails.pl, as the conditions for effective_homebranch and effective_holdingbranch are no longer necessary. > >Sponsored-by: ByWater Solutions >--- > catalogue/moredetail.pl | 7 ++----- > .../intranet-tmpl/prog/en/modules/catalogue/moredetail.tt | 2 +- > 2 files changed, 3 insertions(+), 6 deletions(-) > >diff --git a/catalogue/moredetail.pl b/catalogue/moredetail.pl >index 7f6cc58c73e..2effb1e58c7 100755 >--- a/catalogue/moredetail.pl >+++ b/catalogue/moredetail.pl >@@ -273,11 +273,8 @@ foreach my $item (@items) { > $item_info->{displays} = \@displays if @displays; > } > >- $item_info->{homebranch} = $item->effective_homebranch >- if ( C4::Context->preference('UseDisplayModule') && $item->effective_homebranch ); >- >- $item_info->{holdingbranch} = $item->effective_holdingbranch >- if ( C4::Context->preference('UseDisplayModule') && $item->effective_holdingbranch ); >+ $item_info->{homebranch} = $item->effective_homebranch; >+ $item_info->{holdingbranch} = $item->effective_holdingbranch; > > push @item_data, $item_info; > } >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt >index 6b52cf975bc..1bd301d8503 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt >@@ -180,7 +180,7 @@ > [% IF ( item_level_itypes ) %] > <li class="itype"><span class="label">Item type:</span> [% ITEM_DAT.itype | html %] </li> > [% END %] >- [% IF ( ITEM_DAT.ccode) %] >+ [% IF ( ITEM_DAT.ccode ) %] > <li class="ccode"><span class="label">Collection:</span> [% ITEM_DAT.ccode | html %]</li> > [% END %] > <li class="itemcallnumber"><span class="label">Item call number:</span> [% ITEM_DAT.itemcallnumber | html %]</li> >-- >2.50.1 (Apple Git-155) >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14962
:
190216
|
190217
|
190218
|
190219
|
190220
|
190221
|
190222
|
190223
|
190224
|
190225
|
190226
|
190227
|
190228
|
190229
|
190230
|
190231
|
190232
|
190571
|
190572
|
193719
|
193720
|
193721
|
193722
|
193723
|
193724
|
193725
|
193726
|
193727
|
193728
|
193729
|
193730
|
193731
|
193732
|
193733
|
193734
|
193735
|
193736
|
193737
|
193738
|
193739
|
193740
|
193741
|
193742
|
193743
|
193744
|
193745
|
193746
|
193747
|
193748
|
193749
|
193750
|
193751
|
193752
|
193753
|
193754
|
193755
|
194285
|
194286
|
194287
|
194288
|
194289
|
194290
|
194291
|
194292
|
194293
|
194294
|
194295
|
194296
|
194297
|
194298
|
194299
|
194300
|
194301
|
194302
|
194303
|
194304
|
194305
|
194306
|
194307
|
194308
|
194309
|
194310
|
194311
|
194312
|
194313
|
194314
|
194315
|
194316
|
194317
|
194318
|
194320
|
194321
|
194322
|
194786
|
194795
|
194796
|
194797
|
194798
|
194799
|
194800
|
194801
|
194802
|
194803
|
194804
|
194805
|
194806
|
194807
|
194808
|
194809
|
194813
|
194814
|
194815
|
194816
|
194817
|
194818
|
194819
|
194820
|
194821
|
194822
|
194823
|
194824
|
194825
|
194826
|
194827
|
194828
|
194829
|
194830
|
194831
|
194832
|
194833
|
194834
|
194835
|
194836
|
194837
|
194838
|
194839
|
194840
|
194841
|
194842
|
194843
|
194844
|
194845
|
194846
|
194847
|
194848
|
194849
|
194850
|
194851
|
194852
|
194853
|
194854
|
194855
|
194856
|
194857
|
194858
|
194859
|
194860
|
194861
| 194862 |
194863
|
194864