Bugzilla – Attachment 194863 Details for
Bug 14962
Temp Shelving Location / On Display Module
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14962: (QA follow-up) Returning book now transfers to effective home library
a8f376a.patch (text/plain), 2.61 KB, created by
Jake Deery
on 2026-03-06 17:01:07 UTC
(
hide
)
Description:
Bug 14962: (QA follow-up) Returning book now transfers to effective home library
Filename:
MIME Type:
Creator:
Jake Deery
Created:
2026-03-06 17:01:07 UTC
Size:
2.61 KB
patch
obsolete
>From a8f376ac0e6f20734b1a4bbd45ab196530d098db Mon Sep 17 00:00:00 2001 >From: Jake Deery <jake.deery@openfifth.co.uk> >Date: Fri, 6 Mar 2026 14:43:34 +0000 >Subject: [PATCH] Bug 14962: (QA follow-up) Returning book now transfers to > effective home library > >This patch fixes a design oversight that saw books to into transfer for their homebranch, not effective_homebranch, meaning books would be returned to the wrong place when on display. > >Sponsored-by: ByWater Solutions >--- > C4/Circulation.pm | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index 6a634cf1bfb..07e47f57321 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -349,7 +349,7 @@ sub transferbook { > my $itemnumber = $item->itemnumber; > > # get branches of book... >- my $hbr = $item->homebranch; >+ my $hbr = $item->effective_homebranch; > > # if using Branch Transfer Limits > if ( C4::Context->preference("UseBranchTransferLimits") == 1 ) { >@@ -2340,7 +2340,11 @@ sub AddReturn { > > # if library isn't in same the float group, transfer item to homebranch > $hbr = 'homebranch'; >- $returnbranch = $validate_float ? $branch : $item->$hbr; >+ $returnbranch = $validate_float ? $branch : $item->effective_homebranch; >+ } elsif ( $hbr eq 'homebranch' ) { >+ $returnbranch = $item->effective_homebranch; >+ } elsif ( $hbr eq 'holdingbranch' ) { >+ $returnbranch = $item->effective_holdingbranch; > } else { > $returnbranch = $item->$hbr; > } >@@ -2354,7 +2358,7 @@ sub AddReturn { > my $limit = Koha::Library::FloatLimits->find( { itemtype => $effective_itemtype, branchcode => $branch } ); > if ($limit) { > my $transfer_library = >- Koha::Library::FloatLimits->lowest_ratio_library( $item, $branch, $item->holdingbranch ); >+ Koha::Library::FloatLimits->lowest_ratio_library( $item, $branch, $item->effective_holdingbranch ); > if ( $transfer_library && $transfer_library->branchcode ne $branch ) { > $returnbranch = $transfer_library->branchcode; > $transfer_trigger = 'LibraryFloatLimit'; >@@ -2469,7 +2473,7 @@ sub AddReturn { > > # the holdingbranch is updated if the document is returned to another location. > # this is always done regardless of whether the item was on loan or not >- if ( $item->holdingbranch ne $branch ) { >+ if ( $item->effective_holdingbranch ne $branch ) { > $item->holdingbranch($branch)->store( { log_action => 0, skip_record_index => 1, skip_holds_queue => 1 } ); > } > >-- >2.50.1 (Apple Git-155) >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14962
:
190216
|
190217
|
190218
|
190219
|
190220
|
190221
|
190222
|
190223
|
190224
|
190225
|
190226
|
190227
|
190228
|
190229
|
190230
|
190231
|
190232
|
190571
|
190572
|
193719
|
193720
|
193721
|
193722
|
193723
|
193724
|
193725
|
193726
|
193727
|
193728
|
193729
|
193730
|
193731
|
193732
|
193733
|
193734
|
193735
|
193736
|
193737
|
193738
|
193739
|
193740
|
193741
|
193742
|
193743
|
193744
|
193745
|
193746
|
193747
|
193748
|
193749
|
193750
|
193751
|
193752
|
193753
|
193754
|
193755
|
194285
|
194286
|
194287
|
194288
|
194289
|
194290
|
194291
|
194292
|
194293
|
194294
|
194295
|
194296
|
194297
|
194298
|
194299
|
194300
|
194301
|
194302
|
194303
|
194304
|
194305
|
194306
|
194307
|
194308
|
194309
|
194310
|
194311
|
194312
|
194313
|
194314
|
194315
|
194316
|
194317
|
194318
|
194320
|
194321
|
194322
|
194786
|
194795
|
194796
|
194797
|
194798
|
194799
|
194800
|
194801
|
194802
|
194803
|
194804
|
194805
|
194806
|
194807
|
194808
|
194809
|
194813
|
194814
|
194815
|
194816
|
194817
|
194818
|
194819
|
194820
|
194821
|
194822
|
194823
|
194824
|
194825
|
194826
|
194827
|
194828
|
194829
|
194830
|
194831
|
194832
|
194833
|
194834
|
194835
|
194836
|
194837
|
194838
|
194839
|
194840
|
194841
|
194842
|
194843
|
194844
|
194845
|
194846
|
194847
|
194848
|
194849
|
194850
|
194851
|
194852
|
194853
|
194854
|
194855
|
194856
|
194857
|
194858
|
194859
|
194860
|
194861
|
194862
| 194863 |
194864