Bugzilla – Attachment 194871 Details for
Bug 20956
BorrowersLog is not logging permission changes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20956: (follow-up) Nest permissions data under 'permissions' key in MEMBERS/MODIFY log
763fb92.patch (text/plain), 1.36 KB, created by
Martin Renvoize (ashimema)
on 2026-03-06 17:14:29 UTC
(
hide
)
Description:
Bug 20956: (follow-up) Nest permissions data under 'permissions' key in MEMBERS/MODIFY log
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2026-03-06 17:14:29 UTC
Size:
1.36 KB
patch
obsolete
>From 763fb927867cc429098269c7648223ea2e679922 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@openfifth.co.uk> >Date: Fri, 6 Mar 2026 16:55:28 +0000 >Subject: [PATCH] Bug 20956: (follow-up) Nest permissions data under > 'permissions' key in MEMBERS/MODIFY log > >Changes to patron permissions via member-flags.pl are logged as MEMBERS/MODIFY, >indistinguishable from regular patron field edits. This patch wraps the >before/after permission hashes under a 'permissions' key so that the diff >renderer displays changes as 'permissions.cataloguing' etc., making it clear >the diff relates to permissions rather than first-level patron fields. >--- > members/member-flags.pl | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > >diff --git a/members/member-flags.pl b/members/member-flags.pl >index 0763a3a63f5..eae464a5376 100755 >--- a/members/member-flags.pl >+++ b/members/member-flags.pl >@@ -109,7 +109,10 @@ if ( $op eq 'cud-newflags' ) { > } > > my $permissions_after = $patron->get_from_storage->permissions(); >- logaction( 'MEMBERS', 'MODIFY', $member, $permissions_after, undef, $permissions_before ); >+ logaction( >+ 'MEMBERS', 'MODIFY', $member, { permissions => $permissions_after }, undef, >+ { permissions => $permissions_before } >+ ); > print $input->redirect("/cgi-bin/koha/members/moremember.pl?borrowernumber=$member"); > } else { > >-- >2.53.0 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20956
:
182955
|
185483
|
185491
|
186388
|
187592
|
187593
|
187594
|
188260
|
188261
|
188262
|
188263
|
190686
|
190687
|
190688
|
190689
|
190690
|
191472
|
191473
|
191474
|
191475
|
191476
|
191477
|
191478
|
192506
|
192507
|
192508
|
192509
|
192510
|
192511
|
192512
|
192604
|
192605
|
192606
|
192607
|
192608
|
192609
|
192610
|
194527
|
194528
|
194529
|
194530
|
194531
|
194532
|
194533
|
194534
|
194612
|
194865
|
194866
|
194867
|
194868
|
194869
|
194870
|
194871
|
194882
|
194883
|
194884
|
194885
|
194886
|
194887
|
194888
|
194889
|
194890
|
194892
|
194893
|
194894
|
194895
|
194896
|
194897
|
194898
|
194899